Skip to content

aiops: this-one-time-on-acid - Add repository-specific CodeRabbit configuration #12

Open

Description

@ashleyshaw

AI Ops Summary

Configure CodeRabbit reviews for lightspeedwp/ThisOneTimeOnAcidCom, following its React, Vite and TypeScript guidance.

Verified progress — 18 October 2026

Implementation is substantially merged into the default branch, develop, through #269 and #310. The audited configuration has a single root .coderabbit.yml, inheritance: true, language: en-GB, reviews.profile: chill, corrected src/app/data/mock/ references and separate application, CSS, data, tooling and test guidance. It references guidelines/Guidelines.md and distinguishes application bundler restrictions from modern Node tooling.

A subsequent live review on PR #315 reports repository YAML plus inherited central YAML, CHILL, and findings explicitly sourced from local path instructions. Configuration loading and actual instruction application therefore have live evidence; this does not establish every effective setting or complete acceptance.

Related implementation: TOA-288. Shared onboarding and inherited-setting verification: lightspeedwp/coderabbit#143.

Remaining work and acceptance evidence

  • Reconcile Tailwind documentation with its removal from develop tooling; README, CONTRIBUTING and master guidelines still contain conflicting recommendations.
  • Resolve the import.meta.env prohibition versus documented examples and its use in ThemeToggleES5.tsx.
  • Agree and consistently document the accessibility target: WCAG 2.1 AA/AAA and 2.2 AA/AAA references currently conflict.
  • Align blanket BEM/no-inline-style review rules with documented utility helpers and dynamic-data inline-style exceptions in guidelines/css-architecture.md; test compliant patterns for false positives.
  • Add or correct editorial Markdown coverage: content/ guidance is currently inside a JS/TS/CSS-only glob, not a dedicated content/**/*.md rule.
  • Record full current official schema validation and supported-filename confirmation. A schema annotation and YAML parsing are not full schema validation.
  • Capture source-annotated resolved configuration and verify inherited settings, effective language and guideline-source exclusion. Live inheritance is evidenced, but not every resolved setting.
  • Exercise representative component, CSS, data and bundler changes, including compliant examples, to demonstrate useful findings without false positives.
  • Record the branch distinction: audited main still has the older broad configuration, wrong src/mockData/ reference and no inheritance. Develop completion is not main rollout; determine whether promotion is required before claiming repository-wide completion.

The original sections below retain planning context; this dated assessment supersedes their pre-implementation statements. Unverified acceptance and governance checkboxes remain unchecked.

Build Summary

Improve and validate the existing root CodeRabbit configuration. No application runtime changes.

Linked Stories/Tasks/PRs/Epic

Project: This One Time on Acid — book

Milestones & Timeline

Not specified.

Problem / Opportunity

An initial configuration draft now exists. Inspection found identical .coderabbit.yml and coderabbit.yml files, an unsupported src/mockData/ reference, and contradictory repository guidance that could produce inconsistent reviews.

Approach / Solution

Retain language: en-GB and reviews.profile: chill as the baseline, then prioritise:

  1. Verify configuration loading: confirm the supported filename against current CodeRabbit documentation, validate against its schema and demonstrate that a live review uses the repository instructions. Agree which duplicate configuration to retain before removing anything.
  2. Make instructions path-specific: replace the unsupported src/mockData/ reference after checking the actual src/app/data/ structure. Separate component, CSS, data and bundler checks; cover utility classes and inline styles in JSX too.
  3. Resolve contradictory guidance: reconcile Tailwind recommendations, import.meta.env examples and AA versus AAA accessibility targets before enforcing them. Test representative changes for actionable findings and false positives.

Current official filename support could not be reverified during this review; treat the earlier mandatory .coderabbit.yaml assumption as a verification step, not a confirmed requirement.

Acceptance Criteria

  • AI workflow/agent described
  • Problem/opportunity scoped
  • Success metric defined
  • Documentation updated
  • PR uses correct branch prefix (aiops/)
  • PR description updated with relevant details
  • Changelog entry prepared for PR (if applicable)
  • Labels/types match org standards
  • Supported configuration filename is confirmed and the retained configuration validates against the official schema
  • Develop configuration sets review language to en-GB and profile to chill; full resolved-setting verification remains outstanding
  • Develop path instructions reference guidelines/Guidelines.md
  • Instructions cover accessibility, central mock data, bundler compatibility and semantic BEM CSS, flagging Tailwind utilities and inline styles
  • Live review confirms repository YAML, central inheritance and application of local path instructions; full resolved settings remain outstanding
  • Develop data-path instructions match src/app/data/mock/
  • Review instructions do not contradict the agreed repository guidance
  • Representative reviews detect relevant defects without flagging compliant patterns

Additional Context

Use repository guidelines and CodeRabbit’s configuration reference. Verify the authorised branch prefix against repository guidance before implementation.

Definition of Ready (DoR)

  • AI ops goal described
  • Area/action mapped
  • Acceptance criteria listed
  • Estimate added

Definition of Done (DoD)

  • All acceptance criteria met
  • Solution/automation verified
  • Documentation updated
  • PR uses correct branch prefix (aiops/)
  • PR uses the correct PR template based on type:aiops PR label or linked issue type or linked issue type:aiops label
  • Branch deleted after merge
  • Linked issue(s) updated with latest status and closed after merge,
  • The related epic should not be closed, instead updated with a comment to reflect the closed issue

Supplied implementation report — 18 October 2026

pasted.md

The supplied report describes an unpushed patch against develop at 243c8670472a87c2f4379ec14c22aa68acf7bd76. No implementation branch, pull request or record update was created. These results are author-reported and have not been independently reverified for this update.

Reported changes cover editorial Markdown, Node tooling and test instruction matching; WCAG 2.2 AA minimum; documented CSS-helper and dynamic-inline-style exceptions; contradictory guidance; and local mitigation of inherited WordPress instructions.

Reported validation:

  • Official CodeRabbit schema validation passed; matching matrix passed 28 rows; new tests passed 21/21.
  • Build/Bats passed 12/12; redirect checks passed 6/6.
  • Existing unit and other test suites had failures. Validation ran on Node 22 rather than the repository’s reported Node 24 requirement.
  • Local browser validation failed: unresolved React module imports produced a blank page. This requires separate investigation before promotion, not an application fix within this issue.

Remaining acceptance

  • Recover the complete patch: the supplied file contains a truncated diff and omits the reported validation scripts.
  • Recheck current repository state and existing work before applying anything.
  • Obtain source-annotated resolved configuration and authorised representative-review evidence.
  • Verify Netlify build logs and a relevant develop Deploy Preview; local build success does not establish deployment compatibility.
  • Retain shared-guideline concerns in the existing linked onboarding issue.
  • Report branch/template/label discrepancies without changing governance.
  • Keep acceptance checkboxes unchanged pending verification.

The report states that no deployment settings or production behaviour were changed. Its historical Netlify and branch observations must not be treated as current verified state.

Accessibility decision — 26 October 2026

The agreed target is WCAG 2.2 AA minimum; AAA criteria are advisory. The implementation draft should propose reconciling conflicting AAA requirements in repository guidance. This decision does not establish verified accessibility compliance or authorise repository edits.

Existing acceptance checkboxes remain unchanged pending implementation and verification.

Activity

  1. linear-code commented on Oct 3, 2026

    @linear-code
  2. self-assigned this
    on Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions