Skip to content

feat: draft-form - Capture submissions across both reader aliases #205

Open

Description

@ashleyshaw

Feature Summary

Persist draft requests from /read-the-draft and /read-the-book through one shared component/identity. S reflects one component and two route-metadata cases after shared capture.

Linked Stories/Tasks

Parent: #16. Project: This One Time on Acid — book. Depends on shared capture, deployment/routing and thank-you work.

Milestones & Timeline

No milestone, cycle, due date or release date requested.

Proposed Solution

Update src/app/components/pages/book-site/ReadDraftPage.tsx; preserve aliases in src/app/routes.ts. Use draft-unlock with named required email, matching hidden identity/honeypot and actual pathname. Preserve /read-the-book rather than normalising metadata. Remove special-email bypass; shared validation, pending guard, feedback, failure/value retention/retry. Success navigation only after accepted transport. Centralise revised copy; future-update promises must not imply Brevo enrolment.

Linked Stories/Tasks

No PR linked. Shared foundation owns one detector; no alias-specific detector. Newsletter separate.

Milestones & Timeline

Release timing remains unset.

Acceptance Criteria

  • Both aliases store draft-unlock records with exact visited pathname.
  • Alias behaviour identical except source metadata; bypass address uses ordinary capture.
  • Pending prevents duplicates; failure retains email and permits explicit retry without navigation.
  • Accepted response alone enters agreed thank-you flow.
  • Direct loads/reloads, keyboard, labels/mobile/themes verified.
  • No extra detector or automatic newsletter enrolment; capture receipt does not grant manuscript access.
  • All acceptance criteria met
  • Documentation/changelog updated
  • Tests added/updated
  • PR uses correct branch prefix (feat/)
  • Labels/types match org standards
  • PR description updated with relevant details
  • Changelog entry prepared for PR (if applicable)
  • Labels/types match org standards

Designs / References

Draft component, routes, setup, project Figma Make. Historical ranges 14–22,46–56 belong to original 76b1528 audit.

Dependencies

Shared capture, enabled detector, deployed routing and approved copy remain dependencies. This is a capture proposal, not approved manuscript-entry processing or verification architecture. Reconcile DEC-001–003 before implementation: the complete short website edition requires verified email, including direct chapters; receipt alone grants none. Reader route, verification/returning access, provider, retention/deletion and offline reconciliation remain unresolved; /ebook is only a proposal.

Testing Approach

Exercise each alias independently: direct load/reload, validation, deferred success, immediate duplicates, failed/retried transport and dashboard metadata.

Additional Context

React/Vite and repository styling rules apply. Reader preferences/demonstrations unchanged. LightSpeed Feature defaults retained; Backlog/status:needs-triage conflict approved.


Definition of Ready (DoR)

  • Problem statement and outcome defined
  • Acceptance criteria written (Given/When/Then)
  • Designs/specs/references attached (if relevant)
  • Dependencies mapped
  • Estimate added
  • Stakeholders/approvers listed
  • Milestone/iteration assigned (if applicable)

Definition of Done (DoD)

  • All acceptance criteria met
  • Feature implemented and tested
  • Tests added/updated; CI green
  • Accessibility: WCAG 2.2 AA compliance verified (semantic HTML, keyboard support, colour contrast)
  • Security: input validated, output escaped, no OWASP Top 10 vulnerabilities
  • Performance: no measurable regression introduced
  • Documentation/changelog updated if needed
  • Feature toggles/rollout considered
  • QA verified/UAT approved (if applicable)
  • Release notes prepared; monitoring/alerts set
  • Branch prefix is correct (feat/)
  • Branch deleted after merge
  • Linked issue(s) updated with latest status and closed after merge,
  • The related epic should not be closed, instead updated with a comment to reflect the closed issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions