Skip to content

build: netlify-forms - Align deployment, toolchain and SPA routing #206

Open

Description

@ashleyshaw

Build Summary

PR #457 candidate verification — 24 October 2026

Tested head 6c0f5117fd1a2195e6ffa1c8453a4dacc5f62bf6 on Netlify preview #457, deploy 6adcbb1fa2917cad0ca18dbe.

Chromium rendered the homepage, journal and existing article without reported console errors. Sample deployed JavaScript contained no matched bare React imports. This supports the candidate bundling correction; production remains unverified.

No failed or pending checks were returned; Jest reported 601 passing tests. No local test rerun or human approval was established.

Remaining gaps:

  • No added built-site browser regression coverage.
  • /newsletter renders an application 404; /ebook renders an empty reader shell.
  • Forms processing, detector configuration and submission-history preservation were not tested.
  • Effective Netlify settings, actual build runtime/package manager and production SHA remain unverified.
  • Sentry delivery, authenticated source-map upload/deletion and environment configuration remain unverified. The PR’s broader Sentry/dependency/edge scope needs review.

Do not duplicate PR #457’s bundling change or treat candidate verification as production acceptance.

Establish a reproducible root React/Vite build and verified Netlify deployment before enabling response capture.

Linked Stories/Tasks/PRs/Epic

Parent: #16. Project: This One Time on Acid — book. Shared capture and deployed QA are separate children; no PR linked.

Milestones & Timeline

No milestone, cycle, due date or release date requested.

Steps / Checklist

  • Record Netlify project serving thisonetimeonacid.com, repository connection, production branch and deployed SHA; confirm authorised operator access.
  • Record effective base/package/publish directories, build command, configuration location, Node/package-manager versions and production/preview overrides before changes.
  • Inspect existing forms/history; never delete records to achieve a three-form count.
  • Read AGENTS.md, CONTRIBUTING.md and deployment guidance. Resolve documented pnpm versus tracked package-lock.json and historical npm/pnpm findings; agree/pin supported toolchain and prove clean install/build locally and on Netlify.
  • Keep dependency repairs explicit; no incidental wholesale migration.
  • Verify develop's existing root netlify.toml against the effective Netlify configuration and deployed SHA. Do not repeat the completed configuration migration automatically.
  • Keep root application as build working directory; do not select src/app merely to discover nested configuration.
  • Verify develop's existing regular public/_redirects file and intended SPA fallback against generated output and the identified deployment. Preserve specific redirects and real assets; do not repeat the historical directory-to-file correction automatically.
  • If using a redirect file, verify regular extensionless dist/_redirects; if TOML only, remove conflicting redirect assets. Avoid forced catch-all overriding assets.
  • Verify effective deploy logs/settings, fresh deep links and form POST processing independently.
  • Enable form detection before detector deployment; redeploy after enabling; inspect intended identities without deleting historical forms. Netlify post-processing may remove detection attributes/inject form-name.
  • Task is clearly defined and actionable
  • Automation/scripts referenced if applicable
  • Documentation/changelog updated
  • PR uses correct branch prefix (build/)
  • PR description updated with relevant details
  • Changelog entry prepared for PR (if applicable)
  • Labels/types match org standards

Acceptance Criteria

  • Clean local and Netlify build sequences agree and publish intended application; effective config/logs/SHA recorded.
  • Both draft aliases, waitlist, contact, thank-you, ebook and /newsletter support deep links/reloads; form POST processing works.
  • Historical forms/submissions remain intact.
  • Solution implemented and documented
  • Build passes and is stable
  • No regressions in build/deploy processes
  • Branch prefix is correct (build)

Additional Context

Sentry configuration follow-up

Follow up on the configuration introduced through merged #457, originally on build/netlify-hashed-asset-headers.

The attached troubleshooting record reports that Netlify environment variables were added, but the last inspected preview lacked a DSN. This is historical evidence, not verification of the current deployment.

  • Verify SENTRY_AUTH_TOKEN, SENTRY_ORG, SENTRY_PROJECT and VITE_SENTRY_DSN are available in the intended Netlify build contexts without recording secret values.
  • Identify a fresh deployment built with the intended configuration; record its URL, commit SHA and build-log evidence.
  • Verify authenticated source-map upload and post-upload deletion; confirm deployed .map requests return 404.
  • Confirm the application renders without module-loading errors.
  • Resolve applicable privacy, replay and environment-isolation decisions in decision: website - Define production and release readiness #413 before enabling monitoring or transmitting controlled test events.
  • Once authorised, verify event delivery and a symbolicated stack trace in the intended Sentry project.
  • Record passed, failed and untested checks, remaining blockers and monitoring ownership. Do not infer production readiness.

Branch instructions: Configuration verification requires no new branch. Do not recreate the historical branch or duplicate merged changes. Any code defect requires a separately scoped change following repository branch policy.

Standalone build and deployment readiness

Investigate the reported blank-page failure in the built React/Vite application. Current develop still externalises React-family modules without an import map; browser reproduction remains outstanding. #457 already removes this externalisation—review its current scope and results before proposing duplicate changes.

  • Test the built application in a real browser, checking rendering, module loading, console errors and asset responses.
  • Confirm whether PR feat: sentry - Add error monitoring and fix React bundling #457 resolves the failure; implement only any remaining bounded correction.
  • Add or verify regression coverage against production build output, not build success alone.
  • Record the effective Netlify configuration, deployed SHA, production branch, directories, build command, runtime and package manager.
  • Report each check as passed, failed, skipped or unavailable, with evidence and missing prerequisites.

Repository, AGENTS.md, configuration, redirect asset, build configuration, routing.

Inspected main cb53d2c: root index.html/public/package are active, output dist; package-lock.json tracked, pnpm-lock.yaml absent. Original audit 76b1528 and October 3 npm success/pnpm ERR_PNPM_VERIFY_DEPS_BEFORE_RUN are historical; reproduce before claiming current. Inactive src/app/index.html and src/app/public/ are not active detector locations.

Dependencies: dashboard access, agreed toolchain, shared detector implementation. No reader destination approved: /ebook is To be decided. Verify repository-authorised branch types. LightSpeed Build template content/defaults retained without team rerouting; native Backlog and status:needs-triage coexist as approved.


Definition of Ready (DoR)

  • Build goal and scope defined
  • Checklist prepared
  • Estimate added

Definition of Done (DoD)

  • Issue is fixed and tested
  • All build checklist and acceptance criteria completed
  • Documentation/changelog updated
  • Approved by at least one maintainer
  • PR uses correct branch prefix (build/)
  • PR uses the correct PR template based on type:build PR label or linked issue type or linked issue type:build label
  • Branch deleted after merge
  • Linked issue(s) updated with latest status and closed after merge,
  • The related epic should not be closed, instead updated with a comment to reflect the closed issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions