Skip to content

Fix invalid package name in package.json causing Netlify deploy error - #1

Merged
ashleyshaw merged 1 commit into
mainfrom
agent-deploy-error-4278
Oct 2, 2026
Merged

ashleyshaw merged 1 commit into
mainfrom
agent-deploy-error-4278

Conversation

@netlify-coding

@netlify-coding netlify-coding Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Bugfix Pull Request

Linked issues

Related Linear issue: TOA-2. No closing link is proposed.

Context

The production deploy failed during npm dependency installation with EINVALIDPACKAGENAME, before the Vite application build.

Observed environment: Node 24.21.0, npm 11.19.0.

Implementation context is recorded in the Netlify agent run.

Reproduction

  1. Deploy main revision 0aa668191a225f981bb3cfdca7806438acc0651e.
  2. Netlify attempts npm dependency installation.
  3. Installation fails on malformed dependency keys such as @emotion/react@11.14.0.

Expected: dependencies install and the application builds.

Root Cause

package.json at the failed revision contains version-suffixed dependency keys alongside canonical entries.

The implementation report also describes a subsequent build failure involving missing figma:asset/... images expected under src/assets. That directory was absent from the inspected source listing; the reported count of 56 missing imports has not been independently verified.

Fix Summary

The merged changes:

  • Remove malformed duplicate dependency keys from package.json.
  • Add package-lock.json.
  • Update vite.config.ts to resolve exported images where available, otherwise supply neutral grey placeholders and log missing filenames.
  • Add .gitignore entries for generated dependency, build and Netlify directories.

Original artwork still needs exporting under its expected filenames to replace placeholders.

Verification

Netlify reported the deploy preview ready for commit 62bf2693bca01613dedc5409ebe87aa485247092; the deploy log provides the deployment evidence.

GitHub reports three neutral Netlify checks and two skipped dependency-validation checks. These do not establish complete QA or production deployment success.

  • Tests added/updated to cover the bug
  • Manual verification steps (browsers/devices)
  • Negative/edge cases checked

Risk & Rollback

Risk assessment remains unverified. Placeholder images permit builds without restoring intended artwork, so visual review is still required.

A rollback would require a separately reviewed revert of the merged changes and would reintroduce the original dependency-installation defect.

Changelog

Added

  • npm dependency lockfile.

Changed

  • Missing Figma image assets use neutral placeholders with filename warnings.

Fixed

  • Invalid duplicate dependency names blocking npm installation.

Removed

  • Malformed version-suffixed dependency keys.

Checklist (Global DoD / PR)

  • Code review approved
  • Netlify deploy preview succeeds
  • Clean dependency installation and build verified
  • Placeholder-image behaviour visually reviewed
  • Production deployment succeeds and its link is recorded
  • Active Netlify package-manager and runtime configuration confirmed

@netlify

netlify Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for thisonetimeonacidcom ready!

Name Link
🔨 Latest commit 62bf269
🔍 Latest deploy log https://app.netlify.com/projects/thisonetimeonacidcom/deploys/6abfb269c882a5000924e8e9
😎 Deploy Preview https://deploy-preview-1--thisonetimeonacidcom.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@ashleyshaw
ashleyshaw merged commit 78b0e45 into main Oct 2, 2026
6 checks passed
@linear-code

linear-code Bot commented Oct 2, 2026

Copy link
Copy Markdown

TOA-2

Copy link
Copy Markdown
Member

State and merge-readiness verdict

This PR merged into main on 2 October 2026 at 13:33:03 UTC. This metadata audit does not constitute a code review or a new approval.

  • The recorded approval covers head commit 62bf2693bca01613dedc5409ebe87aa485247092.
  • No review threads are recorded.
  • GitHub’s current mergeable_state=unknown is not evidence of a blocker for an already merged PR.
  • Required-check and branch-protection settings were not verified, so this audit cannot retrospectively certify compliance with every merge gate.

Checks and deployment evidence

The combined commit status is successful for the Netlify deploy-preview context. However, the five check runs comprise:

  • Neutral: Redirect rules, Header rules and Pages changed.
  • Skipped: dependency-validation and dependency-validation (dependabot, hosted).

These are not five passing checks. In particular, there is no passing dependency-validation check, and neutral Netlify checks do not establish routing or header correctness.

Netlify’s comment links the preview deployment log.

The linked Linear issue subsequently records successful production dependency installation, build and deployment, using Node 24.21.0, npm 11.19.0 and Vite 6.3.5. This is later production evidence—not proof that every check passed on this PR’s head.

Metadata and template findings

  1. Title: The existing title describes the defect but lacks the fix: prefix required by title governance. Suggested title:
    fix: netlify - Remove invalid dependency names blocking deployment
  2. Classification: The PR has no labels. Its purpose is fixing broken installation, not a routine dependency upgrade. The canonical type:bug label is available in this repository and is the proposed classification. The Linear issue’s label does not automatically label the GitHub PR.
  3. Description: The body follows the shared bug-template sections, but substitutes a shorter deployment checklist for the complete template Definition of Done. Its unchecked production-deployment item is stale relative to the later Linear evidence. Only evidence-backed items should be marked complete.

The historical branch name also lacks the governed fix/ prefix. This does not explain the skipped checks and does not justify recreating the merged PR.

Remaining uncertainties and scope boundaries

This audit did not verify clean-checkout installation, browser/device coverage, accessibility, placeholder-image appearance, preservation of Vite behaviour or a committed changelog entry. It also did not independently recheck current production health.

Current AGENTS.md and CONTRIBUTING.md prescribe pnpm, conflicting with README guidance and the recorded npm deployment. Those instructions were added after this PR merged. Resolve that conflict before future implementation; do not silently switch package managers or rewrite historical deployment evidence.

Routing and artwork follow-ups remain separate from the original dependency-name defect.

Conclusion: Already merged with recorded approval and successful preview status; later production success is documented in Linear. Complete QA and comprehensive merge-gate compliance are not established by this audit.

ashleyshaw pushed a commit that referenced this pull request Oct 17, 2026
Decision RFC covering 9 critical decisions:
- PKG-001: Package manager (npm-only recommended)
- NODE-001: Node.js pinning (v18 recommended)
- TEST-001: Jest ESM config (enable mode recommended)
- TEST-002: Speckit test baseline (accept 103/104 recommended)
- SPEC-001: Spec Kit paths (keep .github/specs/ recommended)
- STYLE-001: BEM enforcement (enforce-only recommended)
- GH-1: Discussion templates (enable recommended)
- GH-2: PR template routing (keep local recommended)
- GH-3: CODEOWNERS and protection (enable recommended)

Unblocks workstreams TOA-254, TOA-260, TOA-261, TOA-262.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012s4Jtd48fk3QCeT7JTSmZj
ashleyshaw pushed a commit that referenced this pull request Oct 17, 2026
Security fixes:
- Replace execSync with execFileSync to prevent command injection via branch names
- Use argument arrays instead of template strings for safe command execution
- All 3 branch validation calls now use: execFileSync(process.execPath, [VALIDATION_SCRIPT, '--branch', branch], options)

Functional fixes:
- Fix deletion detection: Check localObj (not remoteObj) for all-zero pattern
- Use flexible regex /^0+$/ instead of hard-coded 40-char comparison (supports SHA-1 and SHA-256)
- Handle detached HEAD state: Skip validation when not on a branch (currentBranch === 'HEAD')

Configuration fix:
- Add use_stdin: true to pre-push branch-validate command in lefthook.yml
- Ensures Git ref updates are properly passed to validation script via stdin

Resolves CodeRabbit findings #1-#4 (command injection, deletion detection, configuration)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Baz6RZmSLgVnBPwEscKuFW
ashleyshaw pushed a commit that referenced this pull request Oct 17, 2026
Merges feature 001 specification, implementation plan, research phase, task decomposition and integration checklists for TOA-241 governance epic.

Governance decisions approved (9 total):
- PKG-001: npm-only enforcement
- NODE-001: Pin Node.js to 24 LTS
- TEST-001: Jest ESM configuration
- TEST-002: Accept Speckit 103/104 baseline
- SPEC-001: Keep .github/specs/ location
- STYLE-001: BEM-only CSS enforcement
- GH-1: Enable GitHub Discussions
- GH-2: Keep local PR templates
- GH-3: CODEOWNERS + branch protection

Workstreams unblocked:
- TOA-254: Spec Kit configuration
- TOA-260: Testing infrastructure
- TOA-261: GitHub files (.github)
- TOA-262: Repository configuration

Regressions corrected before merge:
- Path reference: specs/ → .github/specs/
- .nvmrc status: CREATE → existing, verify

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017ftGqLKtMHBMWJmD5Bwimo
ashleyshaw pushed a commit that referenced this pull request Oct 17, 2026
Security fixes:
- Replace execSync with execFileSync to prevent command injection via branch names
- Use argument arrays instead of template strings for safe command execution
- All 3 branch validation calls now use: execFileSync(process.execPath, [VALIDATION_SCRIPT, '--branch', branch], options)

Functional fixes:
- Fix deletion detection: Check localObj (not remoteObj) for all-zero pattern
- Use flexible regex /^0+$/ instead of hard-coded 40-char comparison (supports SHA-1 and SHA-256)
- Handle detached HEAD state: Skip validation when not on a branch (currentBranch === 'HEAD')

Configuration fix:
- Add use_stdin: true to pre-push branch-validate command in lefthook.yml
- Ensures Git ref updates are properly passed to validation script via stdin

Resolves CodeRabbit findings #1-#4 (command injection, deletion detection, configuration)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Baz6RZmSLgVnBPwEscKuFW
ashleyshaw added a commit that referenced this pull request Oct 17, 2026
…plates

feat: Add GitHub Discussions templates (GH-1)
ashleyshaw added a commit that referenced this pull request Oct 17, 2026
…A-289) (#311)

* aiops: Integrate Playwright and BugHerd agents with Testing Agent

Implement TOA-289: Coordinate browser-based testing with feedback intake and validation.

**New Agents:**
- Playwright Agent: Browser automation, reproducibility validation, evidence capture
- BugHerd Agent: Feedback intake, read-only report parsing, response drafting
- Testing Agent: Updated to coordinate both agents

**Key Features:**
- MCP integration verified: BugHerd (read-only) and Playwright (browser control)
- Structured handoff protocol for bug validation workflow
- Three-stage handoff: BugHerd Report → Playwright Validation → Testing Decision
- Read-only BugHerd operations by default; responses drafted locally before posting
- Tested one complete handoff (BugHerd Task #1) without external writes

**Documentation:**
- Agent Handoff Protocol: Standardized format for agent-to-agent communication
- Agent Configuration: MCP setup, workflow, security boundaries
- Updated Testing Agent: Coordination responsibilities and decision-making process

**Verification:**
✅ BugHerd MCP: Connected, TOA project (id: 546928) accessible, 2 tasks readable
✅ Playwright MCP: Connected, browser automation tools available
✅ Handoff Test: BugHerd Task #1 (responsive menu) validated through full workflow
✅ Branch: aiops/toa-289-playwright-bugherd-agents (correct naming convention)

Unresolved: Cross-browser validation (Firefox, Safari, Mobile Chrome) pending.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LpUWQeN2z7skwZytVKdehC

* docs: Clarify BugHerd handoff safety, reporter privacy, and human-only posting

* docs: Clarify Playwright Agent routing for BugHerd-originated requests

Return validation results to the requesting agent:
- BugHerd-originated requests return to BugHerd Agent (for Handoff #3)
- Testing-originated requests return directly to Testing Agent

This resolves ambiguity in the handoff protocol routing.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LpUWQeN2z7skwZytVKdehC

* docs: Rename AgentHandoffProtocol.md to match PascalCase documentation convention

Rename docs/agent-handoff-protocol.md to docs/AgentHandoffProtocol.md to align
with repository documentation naming standards (PascalCase with .md extension).
Update reference in docs/agent-configuration.md accordingly.

Fixes CodeRabbit finding on PR #311.

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants