Repository navigation
fix: netlify - Resolve direct navigation and refresh 404s - #15
netlify-coding[bot] wants to merge 1 commit into
Conversation
✅ Deploy Preview for thisonetimeonacid ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Verdict: technically mergeable, but merge readiness has not yet been demonstrated. Audited head: Verified current state
What remains before merge
Documentation and tracking
After an authorised merge Repeat routing and asset checks on production, record the production deployment URL, and only then close #3 and GitHub #3. Production verification is a post-merge acceptance step, not a prerequisite for merging. Keep the lockfile/overrides mismatch separate and provide its tracking reference. Conclusion: successful deployment and redirect processing support the fix, but do not complete functional acceptance or substitute for review. This is a metadata/evidence audit, not a code approval. |
|
Reviewed head The redirect directory-to-file correction is appropriately narrow. I found no new routing defect in the changed fallback. A build using existing dependencies produced the expected regular redirect file, and preview checks passed direct navigation and refresh for existing journal articles. Updates requested before approval
Recommended addition: a small structural regression check confirming source/generated redirect paths are regular files, their contents match, and the non-forced fallback remains intact. Preview checks covered desktop and mobile-emulated navigation, refresh, real JavaScript/CSS assets and unknown routes. Full reader functionality, accessibility, performance and physical devices were not validated. Unknown routes return the app’s not-found view with HTTP 200; missing assets also receive fallback HTML. Netlify succeeded, but skipped dependency jobs and CodeRabbit’s skipped review are not approval. Before closing the linked issue, obtain maintainer approval, record rollback guidance, and repeat acceptance checks against the authorised production deployment. |
…ce01f1655746ee42)
ac620c4 to
678af60
Compare
Update CONTRIBUTING.md Deployment section to use qualified language matching AGENTS.md, acknowledging that src/app/netlify.toml is only active if the package-directory UI setting is configured to 'src/app/'. - Changed from absolute statements to contingent qualification - Added explicit note that configuration was verified on 3 October 2026 - Added reference to PR #15 for SPA routing configuration - Clarified package-directory UI setting as precondition for src/app/netlify.toml This resolves the contradictions documented in TOA-3 (Issue: Unresolved Decisions on Deployment Configuration). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T6BaHebCVf63qXpvH5r4PK
…manager configuration - Restore public/_redirects as a plain-text file (was incorrectly converted to directory) - Remove pnpm-workspace.yaml and clean pnpm config from package.json - Update AGENTS.md and CONTRIBUTING.md to reflect actual npm-only setup - Remove unresolved decision about _redirects directory since it is now fixed - Update numbered unresolved decisions list after removing resolved item Scope justification: - The _redirects directory corruption from PR #15 breaks Netlify SPA routing - This is a critical structural fix required for deployment to work - Package manager cleanup aligns with npm-only migration and removes dead code This completes the outstanding work for TOA-3 (PR #17) documentation finalization. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DnMETK2WpeFja7GhbsWMC1
Update CONTRIBUTING.md Deployment section to use qualified language matching AGENTS.md, acknowledging that src/app/netlify.toml is only active if the package-directory UI setting is configured to 'src/app/'. - Changed from absolute statements to contingent qualification - Added explicit note that configuration was verified on 3 October 2026 - Added reference to PR #15 for SPA routing configuration - Clarified package-directory UI setting as precondition for src/app/netlify.toml This resolves the contradictions documented in TOA-3 (Issue: Unresolved Decisions on Deployment Configuration). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T6BaHebCVf63qXpvH5r4PK
…manager configuration - Restore public/_redirects as a plain-text file (was incorrectly converted to directory) - Remove pnpm-workspace.yaml and clean pnpm config from package.json - Update AGENTS.md and CONTRIBUTING.md to reflect actual npm-only setup - Remove unresolved decision about _redirects directory since it is now fixed - Update numbered unresolved decisions list after removing resolved item Scope justification: - The _redirects directory corruption from PR #15 breaks Netlify SPA routing - This is a critical structural fix required for deployment to work - Package manager cleanup aligns with npm-only migration and removes dead code This completes the outstanding work for TOA-3 (PR #17) documentation finalization. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DnMETK2WpeFja7GhbsWMC1
|
This PR has merge conflicts with the develop branch. The work has been incorporated into PR #17, which successfully resolves all conflicts and is ready for merge. Closing in favor of PR #17. Generated by Claude Code |
Status
Closed without merge. Final head
678af60received maintainer approval; that approval does not transfer to another contribution.Linked issues
Existing references: GitHub issue #3 and #3. These references do not establish acceptance or introduce new closing keywords.
Historical scope
Three-file correction:
No application, dependency, runtime or environment changes.
Verification limits
Earlier preview checks and redirect-processing results belong to their recorded revisions. They do not certify the current mutable preview or production.
On 19 October, HEAD checks returned 200 for the PR #15 preview journal route, but production deep links returned 404. Deployed SHAs and browser behaviour were not established.
Remaining acceptance
Complete deployment identification, rendered-route/refresh checks, real assets, negative cases, review evidence and rollback under the routing issue.
Use an existing article for positive testing; absent articles are negative cases. Do not reopen this superseded PR merely to complete acceptance.
Original attribution
Implementation agent, as recorded in the original PR: Claude. GitHub author:
netlify-coding[bot]. Model attribution unavailable.Original agent run