Skip to content

fix: netlify - Resolve direct navigation and refresh 404s - #15

Closed
netlify-coding[bot] wants to merge 1 commit into
developfrom
agent-website-ee42
Closed

netlify-coding[bot] wants to merge 1 commit into
developfrom
agent-website-ee42

Conversation

@netlify-coding

@netlify-coding netlify-coding Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Status

Closed without merge. Final head 678af60 received maintainer approval; that approval does not transfer to another contribution.

Linked issues

Existing references: GitHub issue #3 and #3. These references do not establish acceptance or introduce new closing keywords.

Historical scope

Three-file correction:

  • Replace the malformed redirect directory with a regular file, preserving the fallback contents.
  • Update contributor deployment wording.
  • Add the historical changelog entry.

No application, dependency, runtime or environment changes.

Verification limits

Earlier preview checks and redirect-processing results belong to their recorded revisions. They do not certify the current mutable preview or production.

On 19 October, HEAD checks returned 200 for the PR #15 preview journal route, but production deep links returned 404. Deployed SHAs and browser behaviour were not established.

Remaining acceptance

Complete deployment identification, rendered-route/refresh checks, real assets, negative cases, review evidence and rollback under the routing issue.

Use an existing article for positive testing; absent articles are negative cases. Do not reopen this superseded PR merely to complete acceptance.

Original attribution

Implementation agent, as recorded in the original PR: Claude. GitHub author: netlify-coding[bot]. Model attribution unavailable.

Original agent run

@netlify

netlify Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for thisonetimeonacid ready!

Name Link
🔨 Latest commit ac620c4
🔍 Latest deploy log https://app.netlify.com/projects/thisonetimeonacid/deploys/6ac08eb9bcf7f40008ce8a74
😎 Deploy Preview https://deploy-preview-15--thisonetimeonacid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: lightspeedwp/ThisOneTimeOnAcidCom/.coderabbit.yml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 8871c994-71f1-4d0e-ac27-64f8261a90c1
📥 Commits

Reviewing files that changed from the base of the PR and between cb53d2c and 678af60.

📒 Files selected for processing: 3
  • CHANGELOG.md
  • CONTRIBUTING.md
  • public/_redirects

Included review availability: This review used your included allowance. Your plan provides up to 5 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The changelog and contributor guidance document Netlify SPA routing, the public/_redirects fallback, and which deployment settings Netlify reads.

Changes: Netlify routing documentation

Layer / File(s) Summary
Document routing and deployment settings
CONTRIBUTING.md, CHANGELOG.md
Contributor guidance identifies public/_redirects as the SPA routing source and explains which deployment settings Netlify reads. The changelog records the fallback rule and its stated effect on client-side routes.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 678af

The fallback rule remains unchanged, and an unknown journal slug reaches the app’s not-found view rather than returning an HTTP 404. No concrete merge-blocking risk is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: fixing Netlify 404 errors during direct navigation and page refreshes.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@ashleyshaw ashleyshaw changed the title Fix Netlify routing issues for ThisOneTimeOnAcidCom website fix: netlify - Resolve direct navigation and refresh 404s Oct 3, 2026
@ashleyshaw ashleyshaw added the type:bug label Oct 3, 2026 — with Linear

Copy link
Copy Markdown
Member

Verdict: technically mergeable, but merge readiness has not yet been demonstrated.

Audited head: ac620c461fa0809abffd333e56639136db325729.

Verified current state

  • The PR is open and non-draft, with no conflicts; the branch is not behind its target.
  • The Netlify preview deployed successfully. The redirect check passed with “All redirect rules processed without errors.”
  • Header and page checks are neutral; both dependency-validation jobs were skipped. No retrieved check is failing or pending.
  • There are no submitted reviews or review threads. CodeRabbit skipped review because the author is a bot. Its successful status is not an approval.

What remains before merge

  1. Build and generated-output evidence. Record a clean install/build and confirm that dist/_redirects is a regular file containing the intended fallback rule. Retain the deployment log. Redirect processing is confirmed; artifact shape and exact rule count are not independently established.
  2. Deployed preview QA. Record browser/device results for direct navigation and refresh on /journal, /journal/berlin-morning-light and /ebook; homepage and in-app navigation; real JS/CSS responses and content types; rendered unknown-route NotFound; and console errors. HTTP 200 alone does not prove the correct page rendered. Existing local results are implementation-agent reports, not independent preview verification.
  3. Review and release safeguards. Obtain an actual review and document risk and rollback. Confirm the maintainer’s decision on branch naming: agent-website-ee42 lacks the repository’s documented fix/ prefix. Full branch-protection requirements were not independently inspected.

Documentation and tracking

  • CONTRIBUTING.md identifies the effective redirect source, while AGENTS.md and docs/deployment-troubleshooting.md retain conflicting nested-TOML guidance. Clarify the authoritative instructions or explicitly track the inconsistency; moving configuration could activate unrelated settings.
  • bug: netlify - Fix unreadable redirects output and validate routing #3 remains Todo with all six acceptance checkboxes unchecked and no recorded deployed QA. The PR and issue reference one another in their descriptions, but formal Linear links are absent; wording that no implementation PR exists is now stale.
  • The repository has no configured test runner. Record the manual validation used rather than marking automated tests complete.

After an authorised merge

Repeat routing and asset checks on production, record the production deployment URL, and only then close #3 and GitHub #3. Production verification is a post-merge acceptance step, not a prerequisite for merging. Keep the lockfile/overrides mismatch separate and provide its tracking reference.

Conclusion: successful deployment and redirect processing support the fix, but do not complete functional acceptance or substitute for review. This is a metadata/evidence audit, not a code approval.

@ashleyshaw ashleyshaw added release:patch Backwards‑compatible bug fixes requiring a PATCH version bump (e.g., small fixes, docs updates). status:needs-review Awaiting code review area:core meta:needs-changelog labels Oct 5, 2026 — with Linear
@ashleyshaw ashleyshaw added this to the Website v1.0 milestone Oct 5, 2026
@linear-code

linear-code Bot commented Oct 16, 2026

Copy link
Copy Markdown

TOA-4

@ashleyshaw
ashleyshaw self-requested a review October 16, 2026 08:04

Copy link
Copy Markdown
Member

Reviewed head ac620c4.

The redirect directory-to-file correction is appropriately narrow. I found no new routing defect in the changed fallback. A build using existing dependencies produced the expected regular redirect file, and preview checks passed direct navigation and refresh for existing journal articles.

Updates requested before approval

  1. Correct the successful-page example. The new changelog entry uses /journal/berlin-morning-light, which renders “Post not found”. Use /journal/dancefloor-belonging for positive acceptance testing; retain the absent slug as a negative test. No router or content change is needed to correct this example.
  2. Record the pre-existing clean-install blocker. Clean archives of both base and head fail npm ci --no-audit --no-fund on Node 24.21.0/npm 11.19.0 because lockfile entries for path, process, util and inherits are missing. Neither dependency file changes here. Track the repair separately, then attach successful clean-install/build evidence—or record explicit maintainer acceptance of this limitation. The successful build with existing dependencies is not clean-install validation.
  3. Reconcile deployment documentation with PR docs: reconcile repository guidance and fix Netlify routing configuration #17**.** Contributor guidance now describes the public redirect file, but agent guidance and troubleshooting guidance still imply the nested configuration governs deployment. Preserve this PR’s correction when merging the documentation work. Cite verified Netlify settings or identify them as previously reported.

Recommended addition: a small structural regression check confirming source/generated redirect paths are regular files, their contents match, and the non-forced fallback remains intact.

Preview checks covered desktop and mobile-emulated navigation, refresh, real JavaScript/CSS assets and unknown routes. Full reader functionality, accessibility, performance and physical devices were not validated. Unknown routes return the app’s not-found view with HTTP 200; missing assets also receive fallback HTML.

Netlify succeeded, but skipped dependency jobs and CodeRabbit’s skipped review are not approval. Before closing the linked issue, obtain maintainer approval, record rollback guidance, and repeat acceptance checks against the authorised production deployment.

@ashleyshaw
ashleyshaw changed the base branch from main to develop October 16, 2026 14:37
ashleyshaw pushed a commit that referenced this pull request Oct 16, 2026
Update CONTRIBUTING.md Deployment section to use qualified language matching
AGENTS.md, acknowledging that src/app/netlify.toml is only active if the
package-directory UI setting is configured to 'src/app/'.

- Changed from absolute statements to contingent qualification
- Added explicit note that configuration was verified on 3 October 2026
- Added reference to PR #15 for SPA routing configuration
- Clarified package-directory UI setting as precondition for src/app/netlify.toml

This resolves the contradictions documented in TOA-3 (Issue: Unresolved Decisions
on Deployment Configuration).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T6BaHebCVf63qXpvH5r4PK
ashleyshaw pushed a commit that referenced this pull request Oct 16, 2026
…manager configuration

- Restore public/_redirects as a plain-text file (was incorrectly converted to directory)
- Remove pnpm-workspace.yaml and clean pnpm config from package.json
- Update AGENTS.md and CONTRIBUTING.md to reflect actual npm-only setup
- Remove unresolved decision about _redirects directory since it is now fixed
- Update numbered unresolved decisions list after removing resolved item

Scope justification:
- The _redirects directory corruption from PR #15 breaks Netlify SPA routing
- This is a critical structural fix required for deployment to work
- Package manager cleanup aligns with npm-only migration and removes dead code

This completes the outstanding work for TOA-3 (PR #17) documentation finalization.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DnMETK2WpeFja7GhbsWMC1
ashleyshaw pushed a commit that referenced this pull request Oct 16, 2026
Update CONTRIBUTING.md Deployment section to use qualified language matching
AGENTS.md, acknowledging that src/app/netlify.toml is only active if the
package-directory UI setting is configured to 'src/app/'.

- Changed from absolute statements to contingent qualification
- Added explicit note that configuration was verified on 3 October 2026
- Added reference to PR #15 for SPA routing configuration
- Clarified package-directory UI setting as precondition for src/app/netlify.toml

This resolves the contradictions documented in TOA-3 (Issue: Unresolved Decisions
on Deployment Configuration).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T6BaHebCVf63qXpvH5r4PK
ashleyshaw pushed a commit that referenced this pull request Oct 16, 2026
…manager configuration

- Restore public/_redirects as a plain-text file (was incorrectly converted to directory)
- Remove pnpm-workspace.yaml and clean pnpm config from package.json
- Update AGENTS.md and CONTRIBUTING.md to reflect actual npm-only setup
- Remove unresolved decision about _redirects directory since it is now fixed
- Update numbered unresolved decisions list after removing resolved item

Scope justification:
- The _redirects directory corruption from PR #15 breaks Netlify SPA routing
- This is a critical structural fix required for deployment to work
- Package manager cleanup aligns with npm-only migration and removes dead code

This completes the outstanding work for TOA-3 (PR #17) documentation finalization.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DnMETK2WpeFja7GhbsWMC1

Copy link
Copy Markdown
Member

This PR has merge conflicts with the develop branch. The work has been incorporated into PR #17, which successfully resolves all conflicts and is ready for merge.

Closing in favor of PR #17.


Generated by Claude Code

@ashleyshaw ashleyshaw closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core meta:needs-changelog release:patch Backwards‑compatible bug fixes requiring a PATCH version bump (e.g., small fixes, docs updates). status:needs-review Awaiting code review type:bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants