Repository navigation
chore: remove protected-file-change-request governance #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -16,22 +16,22 @@ combinations per agent. | |||||
| ### Core API Services (3 platforms) | ||||||
|
|
||||||
| | Platform | Service | Version | Status | Use Case | | ||||||
| |----------|---------|---------|--------|----------| | ||||||
| | --- | --- | --- | --- | --- | | ||||||
| | **Claude API (Messages)** | Inference | Latest (Haiku 5.5, Opus 5.5, Sonnet 5.5, Fable 5.1; 1M-token context each) | ✅ Active | Agent reasoning, task execution | | ||||||
| | **Claude API Tool Use** | Tool Routing | Tool Runner (beta) | ✅ Available | Dynamic tool selection & execution | | ||||||
| | **Managed Agents** | Cloud Sandbox | Server-hosted | ✅ Available | Long-running governance workflows, budget enforcement | | ||||||
|
|
||||||
| ### Infrastructure Services (2 platforms) | ||||||
|
|
||||||
| | Platform | Service | Version | Status | Use Case | | ||||||
| |----------|---------|---------|--------|----------| | ||||||
| | --- | --- | --- | --- | --- | | ||||||
| | **Prompt Caching** | Optimization | Multi-turn support | ✅ Active | Reduce latency on repeated spec contexts | | ||||||
| | **MCP (Model Context Protocol)** | Integration | Standard | ✅ Active | Connect external tools (GitHub, Slack, databases) | | ||||||
|
|
||||||
| ### Data & Workflow Services (2 platforms) | ||||||
|
|
||||||
| | Platform | Service | Version | Status | Use Case | | ||||||
| |----------|---------|---------|--------|----------| | ||||||
| | --- | --- | --- | --- | --- | | ||||||
| | **Application-owned storage** | Persistent Storage | Git/files/database | ⚠️ Integration required | Store spec artifacts, governance config, audit logs | | ||||||
| | **Claude Docs** | Collaborative Documents interface | Native UI | ⚠️ Interface; no API integration established here | Specification authoring, team review, version history | | ||||||
|
|
||||||
|
|
@@ -45,7 +45,7 @@ combinations per agent. | |||||
| execution boundaries. | ||||||
|
|
||||||
| | Requirement | Platform(s) | Implementation | Status | | ||||||
| |-------------|-------------|-----------------|--------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | Agent discovery | Claude API Tool Use | Register agents via MCP | ✅ T017a Complete | | ||||||
| | Capability contracts | Application-owned storage | Store agent specs in Git at `.claude/agents/`; external storage requires integration | ✅ Git storage in use | | ||||||
| | Execution boundaries | Managed Agents | Enforce via sandbox policies | ✅ Available | | ||||||
|
|
@@ -66,7 +66,7 @@ and identify gaps. | |||||
| mapping platforms to governance requirements. | ||||||
|
|
||||||
| | Assessment Dimension | Platform Assessment | Findings | | ||||||
| |-----|-------|----------| | ||||||
| | --- | --- | --- | | ||||||
| | **Governance Automation** | Claude API + Tool Use | ✅ Supports workflow automation (create, plan, tasks pipeline) | | ||||||
| | **Budget Enforcement** | Managed Agents session spend budget + host-side admission control | ⚠️ `max_tokens` limits one response; a session spend cap is separate. Aggregate token accounting requires host-side enforcement (R7.3), not prompt caching | | ||||||
| | **Audit Trail** | Application-owned storage + MCP logging | ⚠️ Requires log export/storage integration; no native audit dashboard established | | ||||||
|
|
@@ -82,7 +82,7 @@ mapping platforms to governance requirements. | |||||
| agent. | ||||||
|
|
||||||
| | Control Type | Platform | Implementation | Status | | ||||||
| |--------------|----------|-----------------|--------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | Per-response output limit | Claude API Messages | `max_tokens` bounds the output of one response, not total session usage | ✅ API parameter; no aggregate enforcement configured here | | ||||||
| | Session spend budget | Managed Agents | Set session `budget.type: "limit"` and `budget.max*list*cost` at creation; platform stops new model requests at the cap, while an in-flight request may finish | ⚠️ Available platform control; not configured here | | ||||||
| | Aggregate token budget | Host-side admission middleware | Reserve tokens before dispatch; reconcile input/output and cached-token usage across calls, retries, and subagents; block dispatch or cancel on exhaustion | ⏳ Required by R7.3; not implemented here (TOA-271) | | ||||||
|
|
@@ -108,7 +108,7 @@ budget. See TOA-271. | |||||
| complexity and resource needs. | ||||||
|
|
||||||
| | Routing Dimension | Platform | Capability | Status | | ||||||
| |----------|------------|-----------|--------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | Skill discovery | Claude Code API | List skills via MCP | ✅ Available | | ||||||
| | Complexity detection | Claude API Messages | Reasoning agent determines skill tier | ✅ Native | | ||||||
| | Resource allocation | Managed Agents | Assign to appropriate environment tier | ✅ Available | | ||||||
|
|
@@ -126,7 +126,7 @@ establish automatic server-side timeout fallback for this workflow. | |||||
| ### Content & Documentation Agents | ||||||
|
|
||||||
| | Agent | Purpose | Platform Recommendation | MCP Servers | Notes | | ||||||
| |-------|---------|------------------------|-------------|-------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | **Changelog Agent** | Keep a Changelog management | Claude API + Tool Use + Prompt Caching | GitHub | Cache schema/examples; validate entries structurally | | ||||||
| | **Content Strategy Agent** | Portfolio messaging guidance | Claude API + Prompt Caching + Artifact APIs | None | Cache brand guidelines; collaborate on copy | | ||||||
| | **Document Reviewer Agent** | Documentation quality review | Claude API + Tool Runner + Prompt Caching | GitHub | Multi-step review workflow; cache standards | | ||||||
|
|
@@ -135,15 +135,15 @@ establish automatic server-side timeout fallback for this workflow. | |||||
| ### Design & UX Agents | ||||||
|
|
||||||
| | Agent | Purpose | Platform Recommendation | MCP Servers | Notes | | ||||||
| |-------|---------|------------------------|-------------|-------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | **Design Partner Agent** | Design system guidance | Claude API + Prompt Caching + Artifact APIs | Figma | Cache component library; reference tokens | | ||||||
| | **Metadata Agent** | SEO/schema validation | Claude API + Tool Runner + Prompt Caching | None | Structured validation; cache best practices | | ||||||
| | **Client Website Discovery** | Portfolio opportunity discovery | Claude API + Tool Runner + Prompt Caching | Web Search | Multi-step research; cache analysis criteria | | ||||||
|
|
||||||
| ### Development & Code Agents | ||||||
|
|
||||||
| | Agent | Purpose | Platform Recommendation | MCP Servers | Notes | | ||||||
| |-------|---------|------------------------|-------------|-------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | **Branches Agent** | Branch name validation | Implement as **Skill** (not agent) | None | Deterministic rules; no reasoning needed | | ||||||
| | **Labeling Agent** | Issue/PR label assignment | Claude API + Tool Runner + Prompt Caching | GitHub | Multi-step workflow; cache taxonomy | | ||||||
| | **PR Agent** | PR creation & management | Claude API + Tool Runner + Prompt Caching | GitHub | Complex workflow; cache templates | | ||||||
|
|
@@ -152,30 +152,30 @@ establish automatic server-side timeout fallback for this workflow. | |||||
| ### Testing & QA Agents | ||||||
|
|
||||||
| | Agent | Purpose | Platform Recommendation | MCP Servers | Notes | | ||||||
| |-------|---------|------------------------|-------------|-------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | **Playwright Agent** | Browser automation & e2e testing | Claude API + Tool Runner + Prompt Caching | None (local Playwright) | Local execution; cache test scenarios | | ||||||
| | **Testing Agent** | Test strategy & planning | Claude API + Tool Runner + Prompt Caching | None | Multi-step workflows; cache frameworks | | ||||||
|
|
||||||
| ### Issue & Project Management Agents | ||||||
|
|
||||||
| | Agent | Purpose | Platform Recommendation | MCP Servers | Notes | | ||||||
| |-------|---------|------------------------|-------------|-------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | **BugHerd Agent** | Feedback triage & routing | Claude API + Tool Runner + Prompt Caching | BugHerd, GitHub | Multi-step routing; cache triage rules | | ||||||
| | **Issue Agent** | Issue triage & prioritization | Claude API + Tool Runner + Prompt Caching | GitHub | Multi-step workflow; cache priority rules | | ||||||
| | **PRD Agent** | Product requirement specs | Claude API + Tool Runner + Prompt Caching | GitHub | Multi-step drafting; cache templates | | ||||||
|
|
||||||
| ### Analytics & Operations Agents | ||||||
|
|
||||||
| | Agent | Purpose | Platform Recommendation | MCP Servers | Notes | | ||||||
| |-------|---------|------------------------|-------------|-------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | **Metrics Agent** | Metrics collection & analysis | Claude API + Tool Runner + Prompt Caching | Google Analytics, Amplitude | Data aggregation; cache metric definitions | | ||||||
| | **PageSpeed Agent** | Performance monitoring | Claude API + Tool Runner + Prompt Caching | Google PageSpeed Insights | Continuous monitoring; cache Core Web Vitals thresholds | | ||||||
| | **Reporting Agent** | Report generation | Claude API + Tool Runner + Prompt Caching | Multiple (Analytics, GitHub, Email) | Multi-source aggregation; cache templates | | ||||||
|
|
||||||
| ### Release & Deployment Agents | ||||||
|
|
||||||
| | Agent | Purpose | Platform Recommendation | MCP Servers | Notes | | ||||||
| |-------|---------|------------------------|-------------|-------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | **Release Agent** | Release preparation & validation | Claude API + Tool Runner + Prompt Caching | GitHub, Netlify | Multi-step coordination; cache process rules | | ||||||
|
|
||||||
| --- | ||||||
|
|
@@ -195,7 +195,7 @@ establish automatic server-side timeout fallback for this workflow. | |||||
| ### MCP Server Distribution | ||||||
|
|
||||||
| | MCP Server | Agents | Coverage | Status | | ||||||
| |-----------|--------|----------|--------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | **GitHub** | 8 agents | PR/issue/release management, code review | ✅ Primary integration | | ||||||
| | **Figma** | 1 agent | Design system reference | ✅ Design partner | | ||||||
| | **Web Search** | 1 agent | Client discovery research | ✅ Research workflows | | ||||||
|
|
@@ -334,7 +334,7 @@ establish automatic server-side timeout fallback for this workflow. | |||||
| Use this matrix to select the best platform(s) for a given governance task: | ||||||
|
|
||||||
| | Task | Claude API | Managed Agents | Prompt Cache | MCP | Application-owned storage | | ||||||
| |------|-----------|-----------------|----------|-----|-------------| | ||||||
| | --- | --- | --- | --- | | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Add separator cells for all six columns. Line 336 defines six columns for the Proposed fix-| --- | --- | --- | --- |
+| --- | --- | --- | --- | --- | --- |📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
| | Real-time branch validation | ✅ Primary | - | ⚠️ Optional | ✅ For GH access | - | | ||||||
| | Scheduled workflow audits | - | ✅ Primary | - | ✅ For tool access | - | | ||||||
| | Spec collaboration | - | - | - | - | ✅ Git; integrate other storage as needed | | ||||||
|
|
@@ -347,7 +347,7 @@ Use this matrix to select the best platform(s) for a given governance task: | |||||
| ## Known Gaps & Mitigation | ||||||
|
|
||||||
| | Gap | Impact | Mitigation | Status | | ||||||
| |-----|--------|-----------|--------| | ||||||
| | --- | --- | --- | --- | | ||||||
| | No native invocation quota tracking | Budget enforcement incomplete (R7.3) | Custom MCP middleware logging | ⏳ Depends on TOA-271 | | ||||||
| | Audit trail not dashboard-native | Governance transparency limited | Export logs to application-owned storage through an explicit integration | ⚠️ Manual export only | | ||||||
| | Fallback routing is unimplemented | No automatic recovery on timeout | Define and test explicit host-side fallback policy | ⏳ Host workflow work required | | ||||||
|
|
@@ -413,8 +413,6 @@ https://platform.claude.com/docs/en/managed-agents/reference#rate-limits | |||||
| (R7.3) | ||||||
| - **Agentic Workflows**: | ||||||
| `.github/specs/001-repo-governance-layout-and-agentic-workflows/` (R7.1-R7.4) | ||||||
| - **Protected Files Guard**: `.github/workflows/protected-files-guard.yml` | ||||||
| (T017c) | ||||||
|
|
||||||
| --- | ||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: lightspeedwp/ThisOneTimeOnAcidCom
Length of output: 39314
Remove the stale protected-path rules from
research.md.The Impact Analysis now lists
.github/,guidelines/,scripts/,tasks/,src/app/utils/supabase/and the Figma component as ordinary directory-access areas. Other parts of the same file still apply protected-path rules to these areas. This PR removes the protected-file process, so those rules are stale:.github/andguidelines/as YES and LOCKED.utils/andguidelines/as protected.The
protected-files-guard.ymlworkflow is not in the tracked file list..github/PROTECTED_FILES.txtandscripts/validation/check-locked-file-approval.cjsremain, and no workflow in.github/workflows/references that script. Remove these artifacts in the same change. Otherwise, the repository keeps an approval process that no workflow runs.Keep the
tasks/row at Line 341 unlessAGENTS.mdno longer protectstask-list.md.📝 Proposed alignment
🧰 Tools
🪛 LanguageTool
[uncategorized] ~412-~412: The official name of this software platform is spelled with a capital “H”.
Context: ... updates coordinated with lightspeedwp/.github -
guidelines/– Coding standards and ...(GITHUB)
🤖 Prompt for AI Agents