Skip to content

feat: add native replacement foundations for generated plugins #37

Open

Description

@eleshar

Context

The starter-plugin references in lightspeedwp/.github#3387 are obsolete. Generated plugins must use block-plugin-scaffold as their implementation source. This issue tracks the native replacements that are not yet present on develop.

Scope

  • Capability-gated SVG uploads with server-side enshrined/svg-sanitize validation
  • Configured PHPMailer transport and sender values from deployment secrets, plus generated sender settings
  • Environment-aware pre_wp_mail handling for non-production environments
  • Vendor-neutral dataLayer initialisation and named analytics events
  • Capability-checked duplicate-post row action using core post APIs
  • Generated-plugin guidance for the approved plugin register and advisories

Acceptance criteria

  • Each feature is opt-in or has a safe generated-project default
  • Security-sensitive features have capability and sanitisation checks
  • Mail credentials are loaded from deployment configuration and never persisted in generated project files or the database
  • Generated output includes focused tests and updated scaffold documentation
  • No reference to a retired starter repository remains in generated output or guidance
  • docs: add versioned plugin advisories for issue 1396 .github#3387 can link each planned replacement to this issue

Non-goals

  • Reimplementing WordPress core APIs
  • Client-specific analytics or mail configuration
  • SMTP transport credentials in generated source or the database

Activity

  1. eleshar commented on Sep 27, 2026

    @eleshar
    ContributorAuthor

    This issue is now the tracking reference cited by the published advisory

    docs/PLUGIN_ADVISORIES.md is on develop (merged via #3387 in lightspeedwp/.github) and cites this issue as the implementing reference for four rows in its Section 1 table: Safe SVG, WP Mail SMTP / Change Mail Sender, Disable Emails, GTM4WP / Google Site Kit, and Yoast Duplicate Post.

    Those rows are currently marked planned, not available, which is the correct status while this issue is open. The document's own guidance is to verify the generator branch before trusting a status, and to treat an issue as a tracking reference rather than as evidence the feature ships.

    Two things to do when this lands:

    • Update the advisory's status column for these rows from planned to available, with a direct source link rather than an issue link, in line with the document's status legend
    • Confirm the specifics the advisory claims are what actually ships: capability-gated upload_mimes with enshrined/svg-sanitize on upload, a configured PHPMailer transport with sender values from deployment secrets, a pre_wp_mail short-circuit driven by wp_get_environment_type(), vendor-neutral dataLayer events, and a capability-checked duplicate-post row action

    No action needed from me; flagging the coupling so the advisory is not left stale after this ships.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions