Skip to content

feat: template - agent instructions, skills, roles, Spec Kit and guidelines (BPS-10) - #58

Merged
krugazul merged 7 commits into
developfrom
feat/bps-10-agent-instructions
Oct 28, 2026
Merged

krugazul merged 7 commits into
developfrom
feat/bps-10-agent-instructions

Conversation

@krugazul

Copy link
Copy Markdown
Contributor

Part of BPS-10 (#55): agent instructions, skills, roles, Spec Kit and guidelines for generated plugins, adapted from ThisOneTimeOnAcidCom and the organisation's .claude setup. Proven first in lightspeedwp/ls-test (feat/bps-10-agent-instructions), then moved into plugin-template/.

Generated plugins defer to lightspeedwp/.github and never redefine its labels, issue or PR templates, or community files.

Template (plugin-template/)

  • AGENTS.md and CLAUDE.md (0532686), rendered with the plugin's name, namespace, text domain and requirements.
  • Skills and one branch check (00658b1): test, validate, changelog and branch-validation in .agents/skills/, linked from .claude/skills/, and bin/check-branch-name.js, which the pre-commit hook now uses. It copies the organisation validator's types and {type}/{scope}-{title} pattern.
  • Roles and adapters (79f091c): ten roles with Claude Code, Codex and Gemini adapters.
  • Claude Code branch guard hook (550aea4).
  • Spec Kit 1.0.13 (11b3bac) with a block-plugin constitution.
  • guidelines/ (f6a13b6): CSS architecture, accessibility, testing, prompts and reports.

Generator

  • Symlinks are copied as links, and file modes are kept, so Spec Kit's scripts stay executable (00658b1, 11b3bac).
  • .gemini/commands/ and .specify/workflows/ are copied without rendering, like .github/workflows/, so their {{args}} placeholders survive.
  • In template mode, the plugin's .specify/ replaces the scaffold's root one instead of merging with it.
  • compare-toolchain.js covers AGENTS.md, CLAUDE.md, .gitignore and the agent folders, and compares links by target.
  • The output test checks for the scaffold's Copilot Spec Kit instead of .specify (0e1a813).

Testing

  • Round trip: compare-toolchain.js finds no differences between a freshly generated ls-test and the ls-test branch, including the links.
  • node scripts/toolchain/check-generation.js: both fixtures pass generate, install, build, every lint step and test:unit.
  • Template mode on a throwaway copy: links kept, Spec Kit replaced, names rendered, scripts executable.
  • npx jest scripts: only the 11 tests that already fail on develop fail.

Known limits

  • The Claude hook checks the branch of the repository the session was opened in.
  • The Spec Kit manifests are TOTOA's, and their hashes don't match TOTOA's edited files, so specify will treat them as user-modified on an upgrade.

🤖 Generated with Claude Code

krugazul and others added 7 commits October 28, 2026 17:17
Moved back from lightspeedwp/ls-test (BPS-10). Round trip: toolchain files match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…check

Moved back from lightspeedwp/ls-test (BPS-10). The generator now copies
symlinks such as .claude/skills/test -> ../../.agents/skills/test as links.
Round trip: toolchain files match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moved back from lightspeedwp/ls-test (BPS-10). Round trip: toolchain files match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moved back from lightspeedwp/ls-test (BPS-10). Round trip: toolchain files match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moved back from lightspeedwp/ls-test (BPS-10). The generator now keeps file
permissions and copies Spec Kit's placeholder files without rendering.
Round trip: toolchain files match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Moved back from lightspeedwp/ls-test (BPS-10). Round trip: toolchain files match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Generated plugins now have their own .specify (BPS-10), so the test checks
that the scaffold's Copilot integration is not copied instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@linear-code

linear-code Bot commented Oct 28, 2026

Copy link
Copy Markdown

BPS-10

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Note

Some coding-guideline sources were skipped; the reason is listed next to each one. Other guidelines were applied as usual. On a public repository, sources from your configuration are listed without their names.

Skipped guideline sources: 1
a configured source — couldn't be fetched
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Comment @coderabbitai help to get the list of available commands.

@krugazul
krugazul marked this pull request as ready for review October 28, 2026 19:49
@krugazul
krugazul merged commit 2703ae0 into develop Oct 28, 2026
6 of 20 checks passed
@krugazul
krugazul deleted the feat/bps-10-agent-instructions branch October 28, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant