This repository was archived by the owner on Jun 19, 2019. It is now read-only.
handle empty array from server - #22
Open
fridaystreet wants to merge 3 commits into
Open
fridaystreet wants to merge 3 commits into
fridaystreet wants to merge 3 commits into
Conversation
added 3 commits
May 5, 2017 11:31
If the server responds with no items in the array this is not currently ignored and not reflected to the local store.
Change to handle empty response array and override current store[type] with {}
rather than sending requests to the server immediately when adding new items, they are stored locally until calling .save() on the item. can also pass {save:true} option to add() command to add and save at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the server responds with no items in the array this is not currently ignored and not reflected to the local store.
Change to handle empty response array and override current store[type] with {}