Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #138.
--balance-portfolio <json>CLI mode, documented example, and an xUnit project in both solutions.Verification
dotnet test Bot.sln --no-restore -c Release -f net8: 24 passed using .NET SDK 8.0.425.git diff --check: pass.Existing restore/build warnings (including System.CommandLine.Parser framework compatibility and obsolete upstream broker properties) remain unchanged.
Scope
The algorithm returns value changes in a common valuation currency. It does not place orders or infer prices, FX rates, fees or share quantities. Deep snapshots use the existing heap-backed FinancialStorage and live for the lifetime of that store; this does not claim disk persistence. All verification used synthetic data.
Submitting for the 1,000 RUB reward advertised in #138, subject to maintainer acceptance. Implementation and tests were prepared with Codex assistance.