Repository navigation
fix: [M3-7059] - Stop resetting count and disabling Add button when adding node pool to Kubernetes cluster - #10215
Merged
Conversation
mjac0bs
marked this pull request as ready for review
February 21, 2024 22:34
mjac0bs
requested review from
bnussman-akamai and
jaalah-akamai
and removed request for
a team
February 21, 2024 22:34
|
Coverage Report: ✅ |
jdamore-linode
approved these changes
Feb 22, 2024
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks @mjac0bs for the explanation and detailed reproduction/verification tests!
bnussman-akamai
approved these changes
Feb 22, 2024
bnussman-akamai
left a comment
Member
There was a problem hiding this comment.
OMG! This reminds me of some feedback (#7654 (review)) I got on one of my first PRs I did at Linode 🥺
I think in the past we made it reset to 0 so that mobile users had some kind of indication that something actually happened, but I think this change is still fine.
This was referenced Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
🐛 On the cluster creation page, if you remove an added node pool from the cluster summary, that plan in the node pool does not become re-enabled.
Fix: This was happening because the number of node pools in the map was being reset to 0 when a node pool was added to a cluster. When the number input is 0, the add button is disabled. We should not reset the number of node pools to 0 once it has been added to the pool.
Changes 🔄
List any change relevant to the reviewer.
updatePlanCountin the handler for adding a node pool to a cluster.Preview 📷
Screen.Recording.2024-02-21.at.2.28.21.PM.mov
Screen.Recording.2024-02-21.at.2.28.54.PM.mov
How to test 🧪
Prerequisites
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply