Repository navigation
upcoming: [M3-7616] - Add Placement Groups Events and Notifications #10221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b4e4045
Add constants and actions for PG events
carrillo-erik f120e98
Add one more event and fix linking
carrillo-erik 98879ed
Add changesets
carrillo-erik ccf5205
Replace event in serverHandlers
carrillo-erik 656eb77
Add snackbar notifications and fix event text
carrillo-erik 5f0edc0
Fix undefined value causing test failure
carrillo-erik cc70574
Merge branch 'develop' of https://github.com/linode/manager into upcoβ¦
carrillo-erik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
packages/api-v4/.changeset/pr-10221-upcoming-features-1708967424029.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/api-v4": Upcoming Features | ||
| --- | ||
|
|
||
| Placement Groups events and notifications ([#10221](https://github.com/linode/manager/pull/10221)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/manager/.changeset/pr-10221-upcoming-features-1708967386991.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@linode/manager": Upcoming Features | ||
| --- | ||
|
|
||
| Placement Groups events and notifications ([#10221](https://github.com/linode/manager/pull/10221)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,5 @@ | ||||||
| import { AFFINITY_TYPES } from '@linode/api-v4'; | ||||||
| import { useSnackbar } from 'notistack'; | ||||||
| import * as React from 'react'; | ||||||
| import { useParams } from 'react-router-dom'; | ||||||
|
|
||||||
|
|
@@ -53,6 +54,8 @@ export const PlacementGroupsDeleteModal = (props: Props) => { | |||||
| reset: resetUnassignLinodes, | ||||||
| } = useUnassignLinodesFromPlacementGroup(selectedPlacementGroup?.id ?? -1); | ||||||
|
|
||||||
| const { enqueueSnackbar } = useSnackbar(); | ||||||
|
|
||||||
| const error = deletePlacementError || unassignLinodeError; | ||||||
|
|
||||||
| React.useEffect(() => { | ||||||
|
|
@@ -68,10 +71,18 @@ export const PlacementGroupsDeleteModal = (props: Props) => { | |||||
| }; | ||||||
|
|
||||||
| await unassignLinodes(payload); | ||||||
| const toastMessage = `Linode successfully unassigned`; | ||||||
| enqueueSnackbar(toastMessage, { | ||||||
| variant: 'success', | ||||||
| }); | ||||||
| }; | ||||||
|
|
||||||
| const onDelete = async () => { | ||||||
| await deletePlacementGroup(); | ||||||
| const toastMessage = `Placement Group successfully deleted.`; | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| enqueueSnackbar(toastMessage, { | ||||||
| variant: 'success', | ||||||
| }); | ||||||
| onClose(); | ||||||
| }; | ||||||
|
|
||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.