Repository navigation
upcoming: [M3-7814, M3-7819] - Fix Account Switching - #10234
Merged
Merged
Conversation
jaalah-akamai
commented
Feb 27, 2024
| // We don't need to worry about this if we're a proxy user. | ||
| if (!isProxyUser) { | ||
| const parentToken = { | ||
| const parentToken: Token = { |
Contributor
Author
There was a problem hiding this comment.
More type safety
jaalah-akamai
marked this pull request as ready for review
February 27, 2024 21:16
jaalah-akamai
requested review from
abailly-akamai and
mjac0bs
and removed request for
a team
February 27, 2024 21:16
mjac0bs
changed the title
mjac0bs
approved these changes
Feb 27, 2024
mjac0bs
left a comment
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
- From a parent account, I can switch to a proxy account.
- From a proxy account, I can switch to another proxy account.
- From a proxy account, I can switch back to a parent account.
|
Coverage Report: ✅ |
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
jdamore-linode
self-requested a review
February 27, 2024 22:01
jaalah-akamai
requested review from
cliu-akamai
and removed request for
a team
February 27, 2024 22:05
jdamore-linode
approved these changes
Feb 27, 2024
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
🎉 Awesome! Confirmed that the tests now pass without the workarounds (and pushed a commit with those workarounds removed). Feels like a big milestone!
mjac0bs
added
Approved
This was referenced Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
There were a few issues with proxy tokens and loading child users for proxy accounts.
Changes 🔄
Bearerwas missing from the proxy token sending us back to login upon switching.ChildAccountListwhich prevented us from fetching child accounts while in a proxy account. This token needs to be the parent token when logged in as a proxy.Target release date 🗓️
03/04/2024
Preview 📷
parent-child.mp4
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
As an Author I have considered 🤔
Check all that apply