Skip to content

fix: [M3-7880] - Properly reset rebuild modal state #10287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abailly-akamai merged 3 commits into from
Mar 14, 2024
Merged

fix: [M3-7880] - Properly reset rebuild modal state #10287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4041754
rerender rebuild drawer if linode ID changes
abailly-akamai Mar 14, 2024
39848f9
better handling
abailly-akamai Mar 14, 2024
b6b326a
Added changeset: Rebuild modal state not being reset properly
abailly-akamai Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10287-fixed-1710448520468.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

Rebuild modal state not being reset properly ([#10287](https://github.com/linode/manager/pull/10287))
12 changes: 6 additions & 6 deletions packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/LinodeRebuildDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,18 @@ export const LinodeRebuildDialog = (props: Props) => {
const [mode, setMode] = React.useState<MODES>('fromImage');
const [rebuildError, setRebuildError] = React.useState<string>('');

React.useEffect(() => {
if (open) {
setRebuildError('');
}
}, [open]);
const onExitDrawer = () => {
setRebuildError('');
setMode('fromImage');
};

const handleRebuildError = (status: string) => {
setRebuildError(status);
};

return (
<Dialog
TransitionProps={{ onExited: onExitDrawer }}

@abailly-akamai abailly-akamai Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could frankly stop reseting state with useEffect all together on modal/drawer by resetting it via onClose and TransitionProps

I used TransitionProps here to prevent a DOM change before the modal has closed, which is a nice bonus (you could maybe see the content very briefly otherwise)

fullHeight
fullWidth
maxWidth="md"
Expand All @@ -80,8 +80,8 @@ export const LinodeRebuildDialog = (props: Props) => {
{hostMaintenance && <HostMaintenanceError />}
{rebuildError && <Notice variant="error">{rebuildError}</Notice>}
<Typography
sx={{ paddingBottom: theme.spacing(2) }}
data-qa-rebuild-desc
sx={{ paddingBottom: theme.spacing(2) }}

@abailly-akamai abailly-akamai Mar 14, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just alpha ordering - no other change

>
If you can&rsquo;t rescue an existing disk, it&rsquo;s time to rebuild
your Linode. There are a couple of different ways you can do this:
Expand Down