test: [M3-7517 & M3-7519] - Cypress integration tests for Child -> Parent and Child -> Child account switching - #10288
Merged
jdamore-linode merged 11 commits intoMar 21, 2024
Conversation
added 9 commits
March 7, 2024 16:12
… billing page after switch
jdamore-linode
requested review from
cliu-akamai
and removed request for
a team
March 14, 2024 21:11
jdamore-linode
commented
Mar 14, 2024
| mockAlternateChildAccountToken.expiry!, | ||
| mockAlternateChildAccountToken.scopes | ||
| ); | ||
| // TODO Confirm whether toast is intended here. |
Contributor
Author
There was a problem hiding this comment.
Wanted to call this out: do we expect a toast notification to appear when switching from a Child account to another Child account? Seems like proxy_user doesn't get reset in local storage
Contributor
There was a problem hiding this comment.
@jdamore-linode Yea that's a good callout. I'll track this in a new ticket!
…d->Parent and Child->Child flows
jdamore-linode
requested review from
dwiley-akamai and
hana-akamai
and removed request for
a team
March 14, 2024 21:15
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Mar 19, 2024
jaalah-akamai
approved these changes
Mar 19, 2024
dwiley-akamai
approved these changes
Mar 19, 2024
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
The flow looked good to me 🚢
mjac0bs
approved these changes
Mar 20, 2024
mjac0bs
left a comment
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Read through this spec and I think this is well covered, thank you, Joe!
This was referenced Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Adds a couple Cypress tests to test the account switching for Parent -> Child and Child -> Child flows. Additionally makes some fixes and improvements to the existing tests (especially mocks) to resolve some inaccuracies.
I opted to only test these flows from the billing page to cut back on tests required (essentially for the sake of our Cypress Cloud usage) -- my thought is we already have the existing test to cover using the user menu to initiate the flow, but I'm happy to budge on this if there are any thoughts, objections, etc.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
N/A
How to test 🧪
I recommend reviewing these tests using Cypress's debugger (via
yarn cy:debug) so you can see them in action and observe any details, etc. that might stand out.Alternatively, you can run the test from the command line:
yarn && yarn build && yarn start:manager:ci, then:yarn cy:run -s "cypress/e2e/core/parentChild/account-switching.spec.ts"As an Author I have considered 🤔
Check all that apply