Repository navigation
test: [M3-7395] Add new cypress tests to longview landing page - #10321
Merged
Merged
Conversation
cliu-akamai
requested review from
jdamore-linode
and removed request for
a team
March 27, 2024 17:33
|
Coverage Report: ✅ |
jdamore-linode
approved these changes
Apr 2, 2024
Contributor
There was a problem hiding this comment.
Great work @cliu-akamai, really nicely done! Approved pending removal of that stray .skip() (edit: and changeset!)
Contributor
There was a problem hiding this comment.
Suggested change
| it.skip('can install Longview client on a Linode', () => { | |
| it('can install Longview client on a Linode', () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| cy.findByText(`longview-client-${client.id}`).should('be.visible'); | |
| cy.findByText(`${client.label}`).should('be.visible'); |
Very minor change, but this way if the Longview client factory label ever changes the test will still pass 👍
cliu-akamai
requested review from
bnussman-akamai and
jaalah-akamai
and removed request for
bnussman-akamai
April 3, 2024 19:08
cliu-akamai
force-pushed
the
feature/M3-7395
branch
from
April 3, 2024 19:22
5af58f5 to
65f1951
Compare
cliu-akamai
requested review from
dwiley-akamai and
hkhalil-akamai
and removed request for
a team
April 3, 2024 19:22
dwiley-akamai
approved these changes
Apr 4, 2024
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
Tests pass ✅
Code review ✅
| "@linode/manager": Tests | ||
| --- | ||
|
|
||
| Add new cypress tests to longview landing page ([#10321](https://github.com/linode/manager/pull/10321)) |
Contributor
There was a problem hiding this comment.
Suggested change
| Add new cypress tests to longview landing page ([#10321](https://github.com/linode/manager/pull/10321)) | |
| Add new Cypress tests for Longview landing page ([#10321](https://github.com/linode/manager/pull/10321)) |
hkhalil-akamai
approved these changes
Apr 4, 2024
This was referenced Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add new tests to check the empty state message in Longview landing page.
Major Changes 🔄
How to test 🧪