Repository navigation
Tech Story: [M3-7947] - Update storybook to 8.0.5 - #10336
Merged
Merged
Conversation
abailly-akamai
marked this pull request as ready for review
April 1, 2024 17:50
abailly-akamai
requested review from
jdamore-linode and
mjac0bs
and removed request for
a team
April 1, 2024 17:50
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Apr 1, 2024
mjac0bs
approved these changes
Apr 1, 2024
This was referenced Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description 📝
PR to update storybook to
8.0.5I did not change anything to how we're type-checking or compiling. This could be done in subsequent optimizing PRs. It should be a 1/1 update to prepare us to adopt some extra features down the line.
I took a brief stab at adopting
react-docgen(much faster, instead ofreact-docgen-typescript) by default since it is much faster, but type fidelity benefits were lost so best to keep the current config for now.Changes 🔄
8.0.5.mdxfilePreview 📷
There should be no degradation or regression to our storybook as a result of this PR
How to test 🧪
Verification steps
yarn storybookand browse stories to confirm no regressionsyarn build-storybookandstorybook-staticto confirm build will succeeds in our pipelinesAs an Author I have considered 🤔
Check all that apply