Skip to content

test: [M3-7797] - Add Cypress tests for Account billing drawers - #10349

Merged
cliu-akamai merged 2 commits into
linode:developfrom
cliu-akamai:feature/M3-7797
Apr 5, 2024
Merged

cliu-akamai merged 2 commits into
linode:developfrom
cliu-akamai:feature/M3-7797

Conversation

@cliu-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Add new tests to check the Account billing drawers.

Major Changes 🔄

  • Add new cypress tests to tests Make a Payment, Update Billing Contact Information, and Add Payment Method access will be disabled for restricted users or child user accounts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/billing/restricted-user-billing.spec.ts"

@cliu-akamai
cliu-akamai requested a review from a team as a code owner April 3, 2024 19:07
@cliu-akamai
cliu-akamai requested review from bnussman-akamai, jdamore-linode and mjac0bs and removed request for a team April 3, 2024 19:07
@github-actions

github-actions Bot commented Apr 3, 2024 •

Copy link
Copy Markdown

Coverage Report: ✅
Base Coverage: 81.7%
Current Coverage: 81.7%

@mjac0bs mjac0bs changed the title M3-7797 Add Cypress tests for Account billing drawers test: [M3-7797] - Add Cypress tests for Account billing drawers Apr 3, 2024

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Cassie! Please add a changeset under Tests and this looks good to me.

Since we already had test coverage for "Update Billing Contact Information" and "Add Payment Method", I confirmed this PR takes care of testing enabled/disabled access to the last piece of this ticket, "Make a Payment" and all tests pass.

image

@jdamore-linode jdamore-linode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cassie, looks great! Approved pending the changeset that @mjac0bs mentioned

@cliu-akamai
cliu-akamai requested a review from a team as a code owner April 4, 2024 18:03
@cliu-akamai
cliu-akamai requested review from carrillo-erik and hana-akamai and removed request for a team April 4, 2024 18:03
@cliu-akamai
cliu-akamai merged commit 7b79662 into linode:develop Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants