Repository navigation
test: [M3-7768] - Add VM Placement Group landing page empty state test - #10350
abailly-akamai merged 6 commits into
Conversation
There was a problem hiding this comment.
The only real difference here is we're passing an object in the same shape as the feature flag rather than a true or false (however, there's no type safety here that'll catch us if we make a mistake).
|
Coverage Report: ✅ |
abailly-akamai
left a comment
There was a problem hiding this comment.
Looks great! thanks for making this one, looking forward to writing more
There was a problem hiding this comment.
@jdamore-linode since it's a generic we can add type safety here. We'll just have to remember to do it and catch it at code reviews if not present.
Pushed a fix for this one
There was a problem hiding this comment.
Beautiful, wasn't aware of that Flags type. Thanks @abailly-akamai!
By the way, do you know anything about the vmPlacement LD flag? Was that a holdover from earlier in the project that isn't going to be used?
There was a problem hiding this comment.
Correct, lemme delete it now so there's no confusion anymore
|
@jdamore-linode Looks good and thanks for getting this started. My only reservation is whether the folder and spect should be renamed to |
Great callout, thanks @carrillo-erik! If that's more consistent and makes more sense then I absolutely agree. I'll try to take care of that before I sign out tonight! |
1e5690f to
49d2653
Compare
Description 📝
Adds a quick integration test to confirm the VM Placement Groups landing page empty state. The real purpose of this PR is to provide a bare minimum example showing how to mock one of our new object-based feature flags, but it's not much different from mocking our boolean flags.
Changes 🔄
How to test 🧪
yarn cy:run -s "cypress/e2e/core/vmPlacement/vm-placement-landing-page.spec.ts"As an Author I have considered 🤔
Check all that apply