refactor: [M3-7960] - Update Notistack to 3.0.1 - #10357
Conversation
abailly-akamai
changed the title
3.0.1
There was a problem hiding this comment.
Only test to complain from running the suite
There was a problem hiding this comment.
Is it safe to pass an APIError[] to enqueueSnackbar? I'm worried this could cause a crash.
There was a problem hiding this comment.
I think it could be an issue, the first parameter for enqueueSnackbar has a type of SnackbarMessage
There was a problem hiding this comment.
Absolutely not safe 🤦
fixed
There was a problem hiding this comment.
actually it takes React Node as type, which is why is accepted an array. Need to figure out what is does with it
There was a problem hiding this comment.
ok, so yeah, since catch error is any it'll take it.
That being said I tested it and it won't throw with ApiError (just an empty toast, good to know I guess), but it isn't type safe
enqueueSnackbar([{ field: 'label', reason: 'Label is too long' }], {
variant,
});There was a problem hiding this comment.
withSnackbar HOC has been deprecated in favor of direct imports.
In short:
- direct imports for class components
useSnackbarfor functional components
CC @bnussman-akamai for Linode Create v2, tho I guess you handle this already the right way, or will
|
Coverage Report: ❌ |
bnussman-akamai
left a comment
bnussman-akamai
left a comment
There was a problem hiding this comment.
Changes look good to me! ✅
Would like to confirm e2es pass before approving
|
@bnussman-akamai no luck in getting a run to run at all, getting Will need help from @jdamore-linode |
bnussman-akamai
added
the
Dependencies
| '[aria-describedby="notistack-snackbar"]', | ||
| message, | ||
| options | ||
| ); |
There was a problem hiding this comment.
@bnussman-akamai i went with using an existing attribute as a CY selector instead, removing the need to pass a non type-safe one
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Code review ✅
Tested snackbars and general functionality in several places throughout the app ✅
This reverts commit 196167d.
4 participants
Description 📝
Update Notistack to 3.0.1 - pretty light refactor for a major update. This will bring us up to date with the lib and prevent some console errors we saw surface recently between React/Router & Notistack. ex:
Every time we'd have a snackbar pop up ⬆️
see Migration Notes for more info
Changes 🔄
3.0.1Target release date 🗓️
Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
ℹ️ There should be no functional or visual regressions as a result of this PR (1/1 refactor)
How to test 🧪
Verification steps
yarn && yarn upAs an Author I have considered 🤔
Check all that apply