Skip to content

feat: [M3-7959] - Update gecko feature flag to object - #10363

Merged
hana-akamai merged 5 commits into
linode:developfrom
hana-akamai:M3-7959-update-gecko-feature-flag
Apr 11, 2024
Merged

hana-akamai merged 5 commits into
linode:developfrom
hana-akamai:M3-7959-update-gecko-feature-flag

Conversation

@hana-akamai

@hana-akamai hana-akamai commented Apr 8, 2024 •

Copy link
Copy Markdown
Contributor

Description 📝

Update the gecko feature flag from a boolean to an object so we can have more granular control for Beta/GA

Changes 🔄

  • Use gecko2 object feature flag over gecko feature flag
  • Add placeholder logic for GA for the Linode's landing page and region select

Preview 📷

Gecko Beta Gecko GA
image Screenshot 2024-04-08 at 5 24 50 PM
Screenshot 2024-04-08 at 5 25 53 PM image

How to test 🧪

Prerequisites

  • Ensure you have the gecko customer tag (reach out for more info)

Verification steps

Note: You may need to click reset to LD defaults flags in dev tools after each variation switch to see the changes

  • On LD development, test the gecko2 variations:
    • Feature ON, GA OFF
      • No GA Gecko text on the Linode's landing or region select in Linode Create
      • Gecko Beta features display as expected (See M3-7491 for feature overview)
    • Feature ON, GA ON
      • You should see GA Gecko text on the Linode's landing and region select in Linode Create
      • Gecko Beta features display as expected except for the above overwritten for GA
    • Everything OFF (you can just uncheck the Gecko feature flag in the dev tools)
      • You should see no Gecko features

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-akamai hana-akamai added the Gecko LA Relating to Gecko LA label Apr 8, 2024
@hana-akamai hana-akamai self-assigned this Apr 8, 2024
@hana-akamai
hana-akamai requested a review from a team as a code owner April 8, 2024 21:50
@hana-akamai
hana-akamai requested review from abailly-akamai and bnussman-akamai and removed request for a team April 8, 2024 21:50
@github-actions

github-actions Bot commented Apr 8, 2024 •

Copy link
Copy Markdown

Coverage Report: ❌
Base Coverage: 81.8%
Current Coverage: 81.79%

Comment thread packages/manager/src/components/SelectRegionPanel/SelectRegionPanel.tsx Outdated
@abailly-akamai
abailly-akamai self-requested a review April 10, 2024 16:09
Comment thread packages/manager/src/featureFlags.ts Outdated
Comment thread packages/manager/src/featureFlags.ts Outdated

const isEdgeRegionSelected = Boolean(
flags.gecko &&
flags.gecko2?.enabled &&

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to ensure anything touching create is tracked for the refactor work

@abailly-akamai abailly-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for addressing the changes 🚢

@hana-akamai
hana-akamai merged commit 70106ac into linode:develop Apr 11, 2024
@hana-akamai
hana-akamai deleted the M3-7959-update-gecko-feature-flag branch April 11, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gecko LA Relating to Gecko LA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants