Skip to content

change: [UIE-7563] - Delete tooltip displaying for current plan in Databases - #10364

Merged
mjac0bs merged 2 commits into
linode:developfrom
mpolotsk-akamai:feature/UIE-7563-delete-tooltip-displaying-for-current-plan
Apr 10, 2024
Merged

mjac0bs merged 2 commits into
linode:developfrom
mpolotsk-akamai:feature/UIE-7563-delete-tooltip-displaying-for-current-plan

Conversation

@mpolotsk-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Delete "Resizing to smaller plans is not supported" tooltip for current plan in Dedicated tab.

Changes 🔄

Delete "Resizing to smaller plans is not supported" tooltip for current plan in Dedicated tab.

Target release date 🗓️

Release date 04/15/24

Preview 📷

Before After

How to test 🧪

Verification steps

(How to verify changes)

  • Navigate to Databases
  • Choose a Database cluster with Dedicated plan
  • Navigate to Resize tab
  • In the table of plans, the current plan does not have a tooltip.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@mpolotsk-akamai
mpolotsk-akamai requested a review from a team as a code owner April 9, 2024 14:45
@mpolotsk-akamai
mpolotsk-akamai requested review from hana-akamai and hkhalil-akamai and removed request for a team April 9, 2024 14:45
Comment thread packages/manager/src/features/components/PlansPanel/PlanSelection.tsx Outdated
Comment thread packages/manager/.changeset/pr-10364-changed-1712674027336.md Outdated
@hana-akamai hana-akamai added the DBaaS Relates to Database as a Service label Apr 9, 2024
@mpolotsk-akamai
mpolotsk-akamai force-pushed the feature/UIE-7563-delete-tooltip-displaying-for-current-plan branch from 2bfee91 to 95d55c6 Compare April 9, 2024 15:30
@github-actions

github-actions Bot commented Apr 9, 2024 •

Copy link
Copy Markdown

Coverage Report: ✅
Base Coverage: 81.78%
Current Coverage: 81.78%

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Apr 9, 2024

@hkhalil-akamai hkhalil-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some deeper investigation and found the source of the inconsistency to be DatabaseResize.tsx:208. I confirmed that simply deleting the line resolves the bug.

However, I'm not sure why this logic exists in the first place and if deleting it will have other impacts. Any knowledge on this?

@mpolotsk-akamai
mpolotsk-akamai force-pushed the feature/UIE-7563-delete-tooltip-displaying-for-current-plan branch from 95d55c6 to ffb26d2 Compare April 10, 2024 14:26
@mpolotsk-akamai

Copy link
Copy Markdown
Contributor Author

Thank you @hkhalil-akamai,
I deleted the line at DatabaseResize.tsx:208 and tested it out. Everything seems to be working fine.

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mpolotsk-akamai! Did not see any regressions and confirmed that the tooltip is not visible for the current Dedicated plan. I will go ahead and merge this once tests finish running and get it into our 4/15 release.

Screenshot 2024-04-10 at 8 53 35 AM

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Apr 10, 2024
@mjac0bs
mjac0bs merged commit 868bf00 into linode:develop Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants