Repository navigation
test: [M3-7465] - Add Cypress test coverage for Firewall renaming - #10384
Merged
Merged
Conversation
|
Coverage Report: ✅ |
mjac0bs
changed the title
jdamore-linode
self-requested a review
April 22, 2024 16:45
jdamore-linode
approved these changes
Apr 22, 2024
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Nice work @cliu-akamai! Approved pending changesets. Also posted a couple really minor suggestions but this is great as-is. Thanks!
|
|
||
| cy.visitWithLogin(`/firewalls/${firewall.id}`); | ||
|
|
||
| cy.get(`[aria-label="Edit ${firewall.label}"]`).click(); |
Contributor
There was a problem hiding this comment.
Suggested change
| cy.get(`[aria-label="Edit ${firewall.label}"]`).click(); | |
| cy.findByLabelText(`Edit ${firewall.label}`).click(); |
Slightly more clear this way!
Comment on lines
+446
to
+454
| cy.reload(); | ||
|
|
||
| // Confirm firewall label is updated on details page. | ||
| cy.findByText(newFirewallLabel).should('be.visible'); | ||
|
|
||
| cy.visitWithLogin('/firewalls'); | ||
|
|
||
| // Confirm firewall label is updated on landing page. | ||
| cy.findByText(newFirewallLabel).closest('tr').should('be.visible'); |
Contributor
There was a problem hiding this comment.
Suggested change
| cy.reload(); | |
| // Confirm firewall label is updated on details page. | |
| cy.findByText(newFirewallLabel).should('be.visible'); | |
| cy.visitWithLogin('/firewalls'); | |
| // Confirm firewall label is updated on landing page. | |
| cy.findByText(newFirewallLabel).closest('tr').should('be.visible'); | |
| // Confirm Firewall label updates in breadcrumbs. | |
| ui.entityHeader | |
| .find() | |
| .within(() => { | |
| cy.findByText(newFirewallLabel).should('be.visible'); | |
| cy.findByText('firewalls').click(); | |
| }); | |
| // Confirm firewall label is updated on landing page without refresh. | |
| cy.findByText(newFirewallLabel).should('be.visible'); | |
| // Confirm firewall label is updated on landing page after refresh. | |
| cy.reload(); | |
| cy.findByText(newFirewallLabel).should('be.visible'); |
Just a really minor suggestion to slightly improve the coverage by confirming that the label update takes effect without a page refresh (i.e. the React Query cache was successfully updated) and then refreshes the page and confirms the label again (confirming that the label has been updated successfully on the backend, too).
jdamore-linode
added
Ready for Review
Missing Changeset
Add'tl Approval Needed
cliu-akamai
requested review from
carrillo-erik and
dwiley-akamai
and removed request for
a team
April 24, 2024 16:36
carrillo-erik
approved these changes
Apr 24, 2024
dwiley-akamai
approved these changes
Apr 25, 2024
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
Test passes locally & remotely ✅
| }); | ||
|
|
||
| /* | ||
| * - Confirms that firewall's label can be updated on landing page'. |
Contributor
There was a problem hiding this comment.
Suggested change
| * - Confirms that firewall's label can be updated on landing page'. | |
| * - Confirms that firewall's label can be updated on landing page. |
mjac0bs
added
Approved
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add regression tests to rename firewall label on landing page.
Major Changes 🔄
How to test 🧪