Skip to content

refactor: [M3-7661] - Remove linodeCloneUiChanges flag and clean up - #10385

Merged
hkhalil-akamai merged 3 commits into
linode:developfrom
hkhalil-akamai:clean-up-clone-ui-flag
May 1, 2024
Merged

hkhalil-akamai merged 3 commits into
linode:developfrom
hkhalil-akamai:clean-up-clone-ui-flag

Conversation

@hkhalil-akamai

@hkhalil-akamai hkhalil-akamai commented Apr 17, 2024 •

Copy link
Copy Markdown
Contributor

Description 📝

Removes the linodeCloneUiChanges feature flag and permanently enables the associated changes.

Target release date 🗓️

5/13

Note

We don't want to merge this until we are sure we want to remove the feature flag. I am putting this PR up now so it's reviewed and ready when that time comes (expected to be 5/13).

How to test 🧪

Verification steps

Ensure all changes from the clone UI refactor still appear and work as expected:

  • List view for selecting source linode
  • Ability to filter based on linode label
  • Auto filter to Linode when entering the clone flow through a Linode's actions menu
  • Ability to power off linodes directly from the list when selected
  • New notice with power off recommendation

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hkhalil-akamai
hkhalil-akamai marked this pull request as ready for review April 17, 2024 15:17
@hkhalil-akamai
hkhalil-akamai requested a review from a team as a code owner April 17, 2024 15:17
@hkhalil-akamai
hkhalil-akamai requested review from bnussman-akamai, carrillo-erik and jaalah-akamai and removed request for a team April 17, 2024 15:17
@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Apr 19, 2024
@github-actions

github-actions Bot commented Apr 30, 2024 •

Copy link
Copy Markdown

Coverage Report: ✅
Base Coverage: 81.82%
Current Coverage: 81.82%

@hkhalil-akamai
hkhalil-akamai force-pushed the clean-up-clone-ui-flag branch from 5426da4 to a257c16 Compare April 30, 2024 21:14
@hkhalil-akamai
hkhalil-akamai merged commit fce59a2 into linode:develop May 1, 2024
@hkhalil-akamai
hkhalil-akamai deleted the clean-up-clone-ui-flag branch May 1, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Ready for Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants