Skip to content

fix: [M3-7833] - New OBJ Buckets do not appear when created before initial fetch completes - #10388

Merged
cpathipa merged 4 commits into
linode:developfrom
cpathipa:M3-7833
Apr 23, 2024
Merged

cpathipa merged 4 commits into
linode:developfrom
cpathipa:M3-7833

Conversation

@cpathipa

Copy link
Copy Markdown
Contributor

Description 📝

This PR addresses a kind of edge case where new objects do not appear on the buckets landing page if they are created while the landing page is still loading.

Target release date 🗓️

04/29

How to test 🧪

Reproduction steps

(How to reproduce the issue, if applicable)

  • Navigate to Cloud OBJ landing page at /object-storage/buckets
  • While the loading indicator is present, click "Create Bucket", assign a label and region, and click "Create Bucket" within the drawer
  • Observe that once the buckets load, the newly created bucket is not included in the list.
  • Review screen recording attached in the jira ticket.

Verification steps

(How to verify changes)

  • New objects should appear in landing page when created during buckets landing page is in loading state.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@cpathipa
cpathipa requested a review from a team as a code owner April 18, 2024 17:27
@cpathipa
cpathipa requested review from abailly-akamai and hana-akamai and removed request for a team April 18, 2024 17:27
@cpathipa cpathipa self-assigned this Apr 18, 2024
@github-actions

github-actions Bot commented Apr 18, 2024 •

Copy link
Copy Markdown

Coverage Report: ✅
Base Coverage: 81.86%
Current Coverage: 81.86%

@abailly-akamai abailly-akamai left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix - confirmed the behavior with this fix ✅

e2e failure seems unrelated

@hana-akamai hana-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still seeing the issue

Screen.Recording.2024-04-19.at.2.10.52.PM.mov


// "Refresh" keys to include the newly created key
refetch();
queryClient.invalidateQueries([`${queryKey}-buckets`]);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing the issue on this branch as well. These changes are in AccessKeyLanding.tsx but the issue described in the ticket is for the Buckets landing page

@cpathipa

cpathipa commented Apr 23, 2024 •

Copy link
Copy Markdown
Contributor Author

@dwiley-akamai @mjac0bs @hana-linode Yes, looking into that..

…efore initial fetch completes"

This reverts commit 312ecdc.
@cpathipa
cpathipa marked this pull request as draft April 23, 2024 16:31
@cpathipa

cpathipa commented Apr 23, 2024 •

Copy link
Copy Markdown
Contributor Author

@hana-linode and @dwiley-akamai Thank you for pointing this. Updated the changes that address the defect.

Create_Bucket_when_landingpage_is_loading.mov

@cpathipa
cpathipa marked this pull request as ready for review April 23, 2024 17:01

@dwiley-akamai dwiley-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the newly-created bucket appears in the list before and after initial fetch completes ✅

@hana-akamai hana-akamai left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the new bucket appears but it's a bit weird that the other buckets appear out of nowhere. Can we improve this loading state? Maybe we can use the table loading state instead of the circle spinner? https://design.linode.com/?path=/docs/components-table-tablerowloading--documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants