Repository navigation
fix: TopMenu related console errors - #10398
Merged
bnussman-akamai merged 1 commit intoApr 23, 2024
Merged
Conversation
bnussman-akamai
requested review from
hana-akamai and
jdamore-linode
and removed request for
a team
April 23, 2024 14:57
bnussman-akamai
commented
Apr 23, 2024
Member
Author
There was a problem hiding this comment.
The only changes here are
- adding
React.forwardRef - Passing the ref to
a/RouterLink
| <TopMenuTooltip title="Help & Support"> | ||
| <IconButton | ||
| aria-label="Help & Support" | ||
| accessibleAriaLabel="Help & Support" |
Member
Author
There was a problem hiding this comment.
This makes Link happy and sets the aria-label properly
jdamore-linode
approved these changes
Apr 23, 2024
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks for catching and fixing these! It's so easy for console messages to go unnoticed.
Confirmed on a dev and prod build that the console errors are gone and that the top menu seems to be behaving well! Thanks again!
|
Coverage Report: ✅ |
abailly-akamai
approved these changes
Apr 23, 2024
abailly-akamai
left a comment
abailly-akamai
left a comment
Contributor
There was a problem hiding this comment.
Nice! thanks for fixing
- Behavior works as expected on browsers tested (Chrome + FF) ✅
- Semantic HTML + accessibility ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Linkcomponent to accept a ref (had to do this to fix Tooltip ref error)Preview 📷
How to test 🧪
aria-labels 📖As an Author I have considered 🤔