Repository navigation
upcoming: [M3-7932] - Placement Groups copy updates - #10399
Conversation
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
There are several failing unit tests and a Cypress test that need updates here due to these copy changes. Should be quick updates!
@mjac0bs The test updates have been pushed. I've tested both unit and e2e tests locally and everything should be fixed. |
|
Coverage Report: ✅ |
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
Copy updates look good
@carrillo-erik did you get to also confirm warning banners copy?
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
This looks good from what I can tell based on the ticket and the mocks. I didn't see the warning banner permission change and I'm not certain whether there was a specific Assign Drawer change intended. Screenshots always help in the PR description when making copy updates.
The CI failures are unrelated, though linode-config was fixed last week in develop. Joe is aware of the obj test failure.
| minWidth={225} | ||
| />{' '} | ||
| support Placement Groups. | ||
| support placement groups. |
There was a problem hiding this comment.
I did a case sensitive search for "Placement Group[s]" and found more instances of it capitalized. I understand current copy isn't finalized, but below are a few instances (there are more) where capitalization should be revisited by UX and copywriting for consistency in the future: (cc @abailly-akamai, so you can keep an eye out before release)
- "Only regions supporting Placement Groups are listed." in
PlacementGroupsCreateDrawer.tsx - "Loading your Placement Groups..." and "No available Placement Groups" in
PlacementGroupsSelect.tsx - "Placement Groups are not available in this region" and "There are no Placement Groups in this region" in
ConfigureForm.tsx - "There are no Placement Groups in this region." and "This region has reached its Placement Group capacity" in
PlacementGroupsDetailPanel.tsx
There was a problem hiding this comment.
This capitalization business has been a new thing for this feature. I understand the intent but it seems to create a bit of distortion for people, and frankly although the capitalization rules have been explained to me (Product VS Instance) it does not fully make sense to me.
As to the points above, i was hoping to see more constants being made as a result of this PR since we have strings duplicates, hopefully that can be done in the final copy PR
There was a problem hiding this comment.
@mjac0bs There are instances where the copy refers to Placement Group(s) as a product name, in which case both words are capitalized. In other cases, placement group(s) is used as a noun and we don't require capitalization. As the copy changes, so does the way the term is used. Thanks for the list of places to keep an eye on.
There was a problem hiding this comment.
frankly although the capitalization rules have been explained to me (Product VS Instance) it does not fully make sense to me.
I think I'm with ya. 😬 As long as it's clear to users...
@abailly-akamai I did go through the banners and notices copy. |
3 participants
Description 📝
Updates to the text copy as it pertains to the Placement Groups project.
⚠️ This is NOT the final copy ⚠️
Changes 🔄
Target release date 🗓️
04/29/2024
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
As an Author I have considered 🤔