Skip to content

M3-7467 Add Cypress test for Domain cloning - #10403

Merged
cliu-akamai merged 2 commits into
linode:developfrom
cliu-akamai:feature/M3-7467
May 1, 2024
Merged

cliu-akamai merged 2 commits into
linode:developfrom
cliu-akamai:feature/M3-7467

Conversation

@cliu-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Add regression tests to clone domain.

Major Changes 🔄

  • Check users can clone a domain from the Domain landing page

How to test 🧪

yarn cy:run -s "cypress/e2e/core/domains/smoke-clone-domain.spec.ts"

@cliu-akamai
cliu-akamai requested a review from a team as a code owner April 24, 2024 19:33
@cliu-akamai
cliu-akamai requested review from jdamore-linode and removed request for a team April 24, 2024 19:33
@github-actions

github-actions Bot commented Apr 24, 2024 •

Copy link
Copy Markdown

Coverage Report: ✅
Base Coverage: 81.82%
Current Coverage: 81.82%

@jdamore-linode jdamore-linode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Cassie! Don't forget to add a changeset ✅

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this out, Cassie!

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Apr 30, 2024
@cliu-akamai
cliu-akamai requested a review from a team as a code owner May 1, 2024 18:44
@cliu-akamai
cliu-akamai requested review from abailly-akamai and mjac0bs and removed request for a team May 1, 2024 18:44

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cliu-akamai I'm seeing two changesets here. Can we delete one? Otherwise, this looks good to go!

@cliu-akamai
cliu-akamai merged commit fe6ed9f into linode:develop May 1, 2024
@cliu-akamai
cliu-akamai deleted the feature/M3-7467 branch May 1, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Missing Changeset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants