Skip to content

fix: [M3-6856] - Disable Object ACL select filed in loading state - #10412

Merged
cpathipa merged 3 commits into
linode:developfrom
cpathipa:M3-8027
Apr 26, 2024
Merged

cpathipa merged 3 commits into
linode:developfrom
cpathipa:M3-8027

Conversation

@cpathipa

Copy link
Copy Markdown
Contributor

Description 📝

Disable Object ACL select filed in loading state.

Before After
image image

How to test 🧪

Reproduction steps

(How to reproduce the issue, if applicable)

  • Navigate to an Object Storage bucket
  • Click on an Object's name to open its details drawer
  • While "Loading access..." is shown in the ACL select, type something into its text field
  • Observe that when data finishes loading, your input is overwritten by whatever data was loaded

Verification steps

(How to verify changes)

  • Navigate to an Object Storage bucket
  • Click on an Object's name to open its details drawer.
  • Observe ACL filed is disabled while loading state.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@cpathipa
cpathipa requested a review from a team as a code owner April 26, 2024 16:28
@cpathipa
cpathipa requested review from bnussman-akamai and mjac0bs and removed request for a team April 26, 2024 16:28
@cpathipa
cpathipa marked this pull request as draft April 26, 2024 16:28
@cpathipa cpathipa self-assigned this Apr 26, 2024
@cpathipa
cpathipa requested a review from jdamore-linode April 26, 2024 16:30
@cpathipa
cpathipa marked this pull request as ready for review April 26, 2024 16:41
@github-actions

github-actions Bot commented Apr 26, 2024 •

Copy link
Copy Markdown

Coverage Report: ✅
Base Coverage: 81.82%
Current Coverage: 81.82%

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chandra; I'm glad the e2es caught this one. 🚀

Comment thread packages/manager/.changeset/pr-10412-fixed-1714148963193.md Outdated
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Apr 26, 2024

@jdamore-linode jdamore-linode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @cpathipa!

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@cpathipa
cpathipa merged commit 0db7c62 into linode:develop Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants