Skip to content

feat: [M3-8006] – Support disk_encryption in mocks - #10418

Merged
dwiley-akamai merged 2 commits into
linode:developfrom
dwiley-akamai:M3-8006-disk-encryption-update-mocks
Apr 30, 2024
Merged

dwiley-akamai merged 2 commits into
linode:developfrom
dwiley-akamai:M3-8006-disk-encryption-update-mocks

Conversation

@dwiley-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Add disk_encryption to linodeDiskFactory, linodeFactory, and nodePoolFactory

Target release date 🗓️

5/13/24

How to test 🧪

Verification steps

This can be verified with the RQ Dev Tool -- with the MSW on, when going to the Linodes landing page, Linode Details page, and the Kubernetes landing page, you should be able to click into the relevant queries and observe disk_encryption is present.

Screenshots

Screenshot 2024-04-29 at 4 31 13 PM

Screenshot 2024-04-29 at 4 31 30 PM

Screenshot 2024-04-29 at 4 32 19 PM

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@dwiley-akamai dwiley-akamai added the Linode Disk Encryption (LDE) Relating to LDE project label Apr 29, 2024
@dwiley-akamai dwiley-akamai self-assigned this Apr 29, 2024
@dwiley-akamai
dwiley-akamai requested a review from a team as a code owner April 29, 2024 20:34
@dwiley-akamai
dwiley-akamai requested review from abailly-akamai and jdamore-linode and removed request for a team April 29, 2024 20:34
@github-actions

github-actions Bot commented Apr 29, 2024 •

Copy link
Copy Markdown

Coverage Report: ✅
Base Coverage: 81.82%
Current Coverage: 81.82%

@jdamore-linode jdamore-linode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dwiley-akamai! Cypress failures can be ignored 👍

@dwiley-akamai
dwiley-akamai merged commit 1edef12 into linode:develop Apr 30, 2024
@dwiley-akamai
dwiley-akamai deleted the M3-8006-disk-encryption-update-mocks branch April 30, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Linode Disk Encryption (LDE) Relating to LDE project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants