Repository navigation
upcoming: [M3-7874] - Linode Create Refactor - Marketplace - Part 2 - #10419
Merged
bnussman-akamai merged 10 commits intoMay 3, 2024
Conversation
bnussman-akamai
marked this pull request as ready for review
April 29, 2024 22:01
bnussman-akamai
requested review from
carrillo-erik and
dwiley-akamai
and removed request for
a team
April 29, 2024 22:01
bnussman-akamai
commented
Apr 29, 2024
Comment on lines
+70
to
+75
| const displayLabel = decode( | ||
| label | ||
| .replace('Null One-Click', '') | ||
| .replace('One-Click', '') | ||
| .replace('Cluster', '') | ||
| ); |
Member
Author
There was a problem hiding this comment.
This logic will be extracted out in a future PR
|
Coverage Report: ✅ |
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
Are you observing repeated apps in the list also?
Contributor
There was a problem hiding this comment.
Can we fix the three perfectionist/sort-named-imports warnings in this file?
| }); | ||
|
|
||
| await waitFor(() => { | ||
| expect(getByPlaceholderText('Select category')).not.toBeDisabled(); |
Contributor
There was a problem hiding this comment.
Worth storing "Select category" in a const since we use it three times
Member
Author
|
Yeah, I also see repeated apps. For some apps, there are a few variations of them returned by the API. I have not yet implemented the logic that filters the apps based on what is in |
carrillo-erik
approved these changes
Apr 30, 2024
dwiley-akamai
approved these changes
May 2, 2024
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
More work on the Marketplace section of the new Linode Create flow
Note
This PR takes a few more steps in building out the Marketplace tab in the new LInode Create flow. Because of the complexity, I'm doing it incrementally. Much functionality will not be implemented yet
Changes 🔄
appIDquery param (this is needed for parity with existing flow)Preview 📷
How to test 🧪
Prerequisites
Linode Crete v2feature flag using local dev toolsVerification steps
As an Author I have considered 🤔