Repository navigation
fix: [M3-7822] - Prevent Modification of Linode config 'interfaces' Array on No Changes - #10423
Merged
Merged
Conversation
…rray on No Changes
cpathipa
requested review from
bnussman-akamai and
mjac0bs
and removed request for
a team
April 30, 2024 19:07
cpathipa
marked this pull request as draft
April 30, 2024 19:07
…rray on No Changes
|
Coverage Report: ✅ |
dwiley-akamai
approved these changes
May 1, 2024
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
Fix confirmed, no regressions observed ✅
Code review ✅
Contributor
mjac0bs
approved these changes
May 1, 2024
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Confirmed a public interface in eth0 isn't sent in the interfaces list when a config is added or edited. Tested other interface combinations for regressions and confirmed those updated the interface list in the request as expected.
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description 📝
This PR prevents modifying the value of a Linode config's 'interfaces': [] with defaults in the payload when there are no changes made. Refer to the ticket for more details.
Target release date 🗓️
5/13
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply