Skip to content

refactor: [M3-8056] - Query Key Factory for Kubernetes - #10428

Merged
bnussman-akamai merged 4 commits into
linode:developfrom
bnussman-akamai:M3-8056-query-key-factory-for-kubernetes
May 2, 2024
Merged

bnussman-akamai merged 4 commits into
linode:developfrom
bnussman-akamai:M3-8056-query-key-factory-for-kubernetes

Conversation

@bnussman-akamai

@bnussman-akamai bnussman-akamai commented May 1, 2024 •

Copy link
Copy Markdown
Member

Description 📝

  • Query key factory refactor for Kubernetes 🏭

Preview 📷

Note

No UI changes

How to test 🧪

  • Test general create, update, delete operations on Kubernetes clusters and their related node pools 🔍
  • Verify all automated testing related to Kubernetes passes ✅

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the React Query Relating to the transition to use React Query label May 1, 2024
@bnussman-akamai bnussman-akamai self-assigned this May 1, 2024
@bnussman-akamai
bnussman-akamai requested a review from a team as a code owner May 1, 2024 14:31
@bnussman-akamai
bnussman-akamai requested review from cpathipa and hkhalil-akamai and removed request for a team May 1, 2024 14:31
@bnussman-akamai bnussman-akamai changed the title refactor: [M3-8056] - Query Key Factor for Kubernetes refactor: [M3-8056] - Query Key Factory for Kubernetes May 1, 2024
@bnussman-akamai bnussman-akamai added the LKE Related to Linode Kubernetes Engine offerings label May 1, 2024
@github-actions

github-actions Bot commented May 1, 2024 •

Copy link
Copy Markdown

Coverage Report: ❌
Base Coverage: 81.82%
Current Coverage: 81.81%

@hkhalil-akamai hkhalil-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Code review
✅ Manual testing
✅ CI passing

Nice work!

@jaalah-akamai jaalah-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label May 2, 2024
@bnussman-akamai
bnussman-akamai merged commit 21c1c55 into linode:develop May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! LKE Related to Linode Kubernetes Engine offerings React Query Relating to the transition to use React Query

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants