Skip to content

feat: [M3-8018] – "Disk Encryption" section component - #10439

Merged
dwiley-akamai merged 3 commits into
linode:developfrom
dwiley-akamai:M3-8018-disk-encryption-section
May 8, 2024
Merged

dwiley-akamai merged 3 commits into
linode:developfrom
dwiley-akamai:M3-8018-disk-encryption-section

Conversation

@dwiley-akamai

Copy link
Copy Markdown
Contributor

Description 📝

This PR adds a new DiskEncryption component that will be used (with some coming modifications) in the Linode Create, Linode Rebuild, and LKE Create flows.

Target release date 🗓️

5/13/24

Preview 📷

Enabled Disabled
Screenshot 2024-05-06 at 11 54 50 AM Screenshot 2024-05-06 at 10 27 12 AM

How to test 🧪

Verification steps

Temporary code that will be removed prior to merging was added to AccessPanel.tsx so you can see the "Disk Encryption" section in the Linode Create flow or in the Linode Rebuild dialog. You may set L122 in AccessPanel.tsx to false to see the enabled state.

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@dwiley-akamai dwiley-akamai added the Linode Disk Encryption (LDE) Relating to LDE project label May 6, 2024
@dwiley-akamai dwiley-akamai self-assigned this May 6, 2024
@dwiley-akamai
dwiley-akamai requested a review from a team as a code owner May 6, 2024 15:57
@dwiley-akamai
dwiley-akamai requested review from abailly-akamai and cpathipa and removed request for a team May 6, 2024 15:57
Comment thread packages/manager/src/components/AccessPanel/AccessPanel.tsx
@github-actions

github-actions Bot commented May 6, 2024 •

Copy link
Copy Markdown

Coverage Report: ❌
Base Coverage: 82.01%
Current Coverage: 81.99%

@cpathipa cpathipa added the Approved Multiple approvals and ready to merge! label May 8, 2024
@dwiley-akamai
dwiley-akamai merged commit 3e69050 into linode:develop May 8, 2024
@dwiley-akamai
dwiley-akamai deleted the M3-8018-disk-encryption-section branch May 8, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Linode Disk Encryption (LDE) Relating to LDE project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants