Skip to content

refactor: [M3-8080] - Linode Create Refactor - Add API/CLI Modal - #10442

Merged
bnussman-akamai merged 7 commits into
linode:developfrom
bnussman-akamai:M3-8080-linode-create-refactor-linode-api-cli-modal
May 14, 2024
Merged

refactor: [M3-8080] - Linode Create Refactor - Add API/CLI Modal#10442
bnussman-akamai merged 7 commits into
linode:developfrom
bnussman-akamai:M3-8080-linode-create-refactor-linode-api-cli-modal

Conversation

@bnussman-akamai

Copy link
Copy Markdown
Member

Description 📝

  • Adds the "Create using Command Line" button to the new Linode Create flow 🎉

Preview 📷

Screenshot 2024-05-06 at 4 15 35 PM

How to test 🧪

Prerequisites

  • Enable the Linode Create v2 feature flag using local dev tools

Verification steps

  • Verify you see the Create Using Command Line button at the bottom of the new Linode Create flow
  • Verify the create using command line works as expected and opens the dialog with the correct information 📄

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai
bnussman-akamai requested a review from a team as a code owner May 6, 2024 20:22
@bnussman-akamai bnussman-akamai self-assigned this May 6, 2024
@bnussman-akamai
bnussman-akamai requested review from hana-akamai and jdamore-linode and removed request for a team May 6, 2024 20:22
@github-actions

github-actions Bot commented May 6, 2024

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 82%
Current Coverage: 82%

@jaalah-akamai jaalah-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ CLI works - was able to create a linode with both curl and linode cli

@hana-akamai

Copy link
Copy Markdown
Contributor

It looks like VPC isn't supported 🤔

This branch Prod
image image
image image

@bnussman-akamai

Copy link
Copy Markdown
Member Author

VPC issue is fixed ✅ @hana-linode

@hana-akamai

Copy link
Copy Markdown
Contributor

@bnussman looks like something is off with the metadata encoding

https://www.base64decode.org/

This branch Prod
image image

@bnussman-akamai

Copy link
Copy Markdown
Member Author

@hana-linode should be fixed by c4c52fe

@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 14, 2024
@bnussman-akamai
bnussman-akamai merged commit 013dc2b into linode:develop May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Linode Create Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants