Skip to content

fix: [M3-8057] - Disable dedicated > shared DatabaseResize same plan size selection - #10450

Merged
abailly-akamai merged 2 commits into
linode:developfrom
abailly-akamai:M3-8057
May 9, 2024
Merged

abailly-akamai merged 2 commits into
linode:developfrom
abailly-akamai:M3-8057

Conversation

@abailly-akamai

@abailly-akamai abailly-akamai commented May 8, 2024 •

Copy link
Copy Markdown
Contributor

Description 📝

My previous PR (not yet released) introduced a regressions where the database resize plans disabled due to being smaller were not reflecting the original logic, due to a flaw in my understanding of the feature.

For plans of the same size:
expected:

  • resizing from dedicated to shared : not allowed
  • resizing from shared to dedicated : allowed

The current bug in develop is the fact that resizing from dedicated to shared is allowed in Cloud Manager, but will result in an API error

Changes 🔄

  • Add smallerPlan filtering to the extractPlansInformation util and use original DatabaseResize smaller plan disabling logic
  • Update tests

Target release date 🗓️

5/13/2024

Preview 📷

Before After
Screen Shot 2024-05-08 at 15 49 19 Screen Shot 2024-05-08 at 15 47 55
Screen Shot 2024-05-08 at 15 49 24 Screen Shot 2024-05-08 at 15 48 45

How to test 🧪

Prerequisites

Reproduction steps

on develop

Verification steps

on this branch

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this May 8, 2024
@abailly-akamai
abailly-akamai marked this pull request as ready for review May 8, 2024 19:54
@abailly-akamai
abailly-akamai requested a review from a team as a code owner May 8, 2024 19:54
@abailly-akamai
abailly-akamai requested review from jdamore-linode and mjac0bs and removed request for a team May 8, 2024 19:54
@abailly-akamai abailly-akamai changed the title fix: [M3-8057] - DatabaseResize smaller plans disabling fix: [M3-8057] - Disable dedicated > shared DatabaseResize same plan size selection May 8, 2024
@abailly-akamai

Copy link
Copy Markdown
Contributor Author

CC @mpolotsk-akamai

@github-actions

github-actions Bot commented May 8, 2024

Copy link
Copy Markdown

Coverage Report: ✅
Base Coverage: 82.01%
Current Coverage: 82.01%

@bnussman-akamai bnussman-akamai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed a shared plan of the same disk size is disabled ✅

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered an account limit error with the 16gb, but tested the same with a smaller plan size to confirm the bug and fix.

  • Confirmed now I cannot resize a dedicated plan to a shared plan of the same size; it must be a greater size.
  • Confirmed I can resize a shared plan to a dedicated plan of the same size or greater still.
  • Confirmed tests are passing and the CI failure is irrelevant (and now fixed in develop).

Screenshot 2024-05-08 at 7 47 31 PM

@mjac0bs mjac0bs added DBaaS Relates to Database as a Service Approved Multiple approvals and ready to merge! labels May 8, 2024
@abailly-akamai
abailly-akamai merged commit 0bff517 into linode:develop May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants