Repository navigation
fix: [M3-8057] - Disable dedicated > shared DatabaseResize same plan size selection - #10450
Merged
Merged
Conversation
abailly-akamai
marked this pull request as ready for review
May 8, 2024 19:54
abailly-akamai
requested review from
jdamore-linode and
mjac0bs
and removed request for
a team
May 8, 2024 19:54
Contributor
Author
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
May 8, 2024
bnussman-akamai
approved these changes
May 8, 2024
bnussman-akamai
left a comment
Member
There was a problem hiding this comment.
Confirmed a shared plan of the same disk size is disabled ✅
mjac0bs
approved these changes
May 8, 2024
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
I encountered an account limit error with the 16gb, but tested the same with a smaller plan size to confirm the bug and fix.
- Confirmed now I cannot resize a dedicated plan to a shared plan of the same size; it must be a greater size.
- Confirmed I can resize a shared plan to a dedicated plan of the same size or greater still.
- Confirmed tests are passing and the CI failure is irrelevant (and now fixed in develop).
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description 📝
My previous PR (not yet released) introduced a regressions where the database resize plans disabled due to being smaller were not reflecting the original logic, due to a flaw in my understanding of the feature.
For plans of the same size:
expected:
The current bug in develop is the fact that resizing from dedicated to shared is allowed in Cloud Manager, but will result in an API error
Changes 🔄
extractPlansInformationutil and use original DatabaseResize smaller plan disabling logicTarget release date 🗓️
5/13/2024
Preview 📷
How to test 🧪
Prerequisites
Dedicated 16 GBdb planReproduction steps
on develop
Verification steps
on this branch
As an Author I have considered 🤔
Check all that apply