test: [M3-7954] - Cypress integration test to add SSH key via Profile page - #10477
Merged
Conversation
|
Coverage Report: ✅ |
mjac0bs
self-requested a review
May 20, 2024 18:29
mjac0bs
reviewed
May 21, 2024
mjac0bs
left a comment
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
@cliu-akamai Looks good overall with the spec passing and covering the expected happy path and the potential error flows.
I suggested a few minor changes. Please add a changeset too before I approve.
cliu-akamai
force-pushed
the
feature/M3-7954
branch
from
June 3, 2024 20:58
9d70015 to
124c0b6
Compare
cliu-akamai
requested review from
hkhalil-akamai and
mjac0bs
and removed request for
a team
June 3, 2024 20:58
mjac0bs
added
Add'tl Approval Needed
jdamore-linode
approved these changes
Jun 4, 2024
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Awesome work @cliu-akamai, the tests look and run great!
Comment on lines
+21
to
+27
| const randomKey = randomString(400, { | ||
| uppercase: true, | ||
| lowercase: true, | ||
| numbers: true, | ||
| spaces: false, | ||
| symbols: false, | ||
| }); |
Contributor
There was a problem hiding this comment.
I might suggest shortening this string to something like 100-200 characters since we're dealing with mock data anyway, only because it takes Cypress nearly 10 seconds to type it out each time 😅 (same suggestion for line 127)
bnussman-akamai
added
Approved
hkhalil-akamai
approved these changes
Jun 5, 2024
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ SSH key integration tests passing
Great work!
This was referenced Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add integration test to add SSH key via Profile page.
Major Changes 🔄
How to test 🧪