test: [M3-7957] - Add Cypress integration test for SSH key update and delete - #10542
Merged
Merged
Conversation
cliu-akamai
requested review from
AzureLatte and
jdamore-linode
and removed request for
a team
June 3, 2024 22:18
|
Coverage Report: ✅ |
mjac0bs
changed the title
jdamore-linode
approved these changes
Jun 4, 2024
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Great work @cliu-akamai, posted a couple really minor suggestions for the comments, but the tests look perfect! Approved pending adding changeset with yarn changeset 👍
Comment on lines
+424
to
+430
| * Intercepts POST request to create an SSH key. | ||
| * | ||
| * @param sshKey - SSH key object with which to mock response. | ||
| * @returns Cypress chainable. | ||
| */ | ||
| export const interceptCreateSSHKey = (): Cypress.Chainable<null> => { | ||
| return cy.intercept('POST', apiMatcher(`profile/sshkeys*`)); | ||
| }; |
Contributor
There was a problem hiding this comment.
Are we using this util anywhere?
|
|
||
| describe('SSH keys', () => { | ||
| /* | ||
| * - Vaildates SSH key update flow using mock data. |
Contributor
There was a problem hiding this comment.
Suggested change
| * - Vaildates SSH key update flow using mock data. | |
| * - Validates SSH key update flow using mock data. |
|
|
||
| mockGetSSHKeys(mockSSHKeys).as('getSSHKeys'); | ||
|
|
||
| // Navigate to SSH key landing page, click the "Add an SSH Key" button. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Navigate to SSH key landing page, click the "Add an SSH Key" button. | |
| // Navigate to SSH key landing page. |
|
|
||
| mockGetSSHKeys([mockSSHKey]).as('getSSHKeys'); | ||
|
|
||
| // Navigate to SSH key landing page, click the "Add an SSH Key" button. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Navigate to SSH key landing page, click the "Add an SSH Key" button. | |
| // Navigate to SSH key landing page. |
cliu-akamai
requested review from
bnussman-akamai and
hana-akamai
and removed request for
a team
June 25, 2024 17:04
jaalah-akamai
added
Approved
This was referenced Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add integration test to update and delete SSH key via Profile page.
Major Changes 🔄
How to test 🧪