test: [M3-8133] - Add Cypress test for Login History page - #10575
Merged
Merged
Conversation
|
Coverage Report: ✅ |
mjac0bs
changed the title
dwiley-akamai
self-requested a review
June 25, 2024 17:58
dwiley-akamai
approved these changes
Jun 25, 2024
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
Test passed locally & remotely ✅
Can we add a changeset under the Tests category?
Comment on lines
+209
to
+211
| // cy.findByText(mockSuccessfulLogin.status, { exact: false }).should( | ||
| // 'be.visible' | ||
| // ); |
Contributor
There was a problem hiding this comment.
Is this (and L196-198) commented out pending something that's forthcoming or can it be removed now?
jdamore-linode
approved these changes
Jun 25, 2024
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Nice work @cliu-akamai! Approved pending both the points Dajahi mentioned:
- Changeset addition
- Stray comments that could possibly be cleaned up
Comment on lines
+21
to
+31
|
|
||
| /** | ||
| * Helper text that appears above the login history table. | ||
| */ | ||
| export const loginHelperText = | ||
| 'Logins across all users on your account over the last 90 days.'; | ||
|
|
||
| /** | ||
| * Empty state message that appears when there is no item in the login history table. | ||
| */ | ||
| export const loginEmptyStateMessageText = 'No account logins'; |
cliu-akamai
requested review from
AzureLatte and
carrillo-erik
and removed request for
a team
July 8, 2024 18:55
Contributor
|
@cliu-akamai You'll probably have to pull in the latest changes from |
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add integration test for Login History page.
Major Changes 🔄
How to test 🧪