Skip to content

change: [M3-8199] - Auto-populate Image Label based on linode and disk names - #10604

Merged
hkhalil-akamai merged 9 commits into
linode:developfrom
hkhalil-akamai:M3-8199-auto-image-label
Jun 27, 2024
Merged

hkhalil-akamai merged 9 commits into
linode:developfrom
hkhalil-akamai:M3-8199-auto-image-label

Conversation

@hkhalil-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Auto-populate the Image Label field based on the selected Linode and Disk.

Changes 🔄

  • Auto-populate image labels using the following format: linode_label-disk_label.
  • Change field label from "Label" to "Image Label" based on UX mockups
  • Add unit tests

Target release date 🗓️

7/8

Preview 📷

Before After
Screen.Recording.2024-06-21.at.4.38.01.PM.mov
Screen.Recording.2024-06-21.at.4.37.30.PM.mov

How to test 🧪

Prerequisites

  • Go to images/create/disk

Reproduction steps

  • Select a Linode and Disk and observe the Image Label field is not auto-populated

Verification steps

  • Select a Linode and Disk and observe the Image Label field is auto-populated in the following format: linode_label-disk_label.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hkhalil-akamai
hkhalil-akamai marked this pull request as ready for review June 21, 2024 20:55
@hkhalil-akamai
hkhalil-akamai requested a review from a team as a code owner June 21, 2024 20:55
@hkhalil-akamai
hkhalil-akamai requested review from jaalah-akamai and jdamore-linode and removed request for a team June 21, 2024 20:55

@bnussman-akamai bnussman-akamai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clear the label field if the user clears the Linode / Disk?

Screen.Recording.2024-06-21.at.6.30.08.PM.mov

Comment thread packages/manager/src/features/Images/ImagesCreate/CreateImageTab.tsx Outdated
Comment thread packages/manager/src/features/Images/ImagesCreate/CreateImageTab.tsx Outdated
Comment thread packages/manager/src/features/Images/ImagesCreate/CreateImageTab.tsx Outdated
@hkhalil-akamai
hkhalil-akamai requested a review from a team as a code owner June 24, 2024 20:37
@hkhalil-akamai
hkhalil-akamai requested review from AzureLatte and removed request for a team June 24, 2024 20:37
@github-actions

github-actions Bot commented Jun 24, 2024

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 82.43%
Current Coverage: 82.43%

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Jun 25, 2024
@hkhalil-akamai
hkhalil-akamai merged commit 9416b1b into linode:develop Jun 27, 2024
@hkhalil-akamai
hkhalil-akamai deleted the M3-8199-auto-image-label branch June 27, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Image Service Gen2

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants