Skip to content

feat: [OCA-1381] - Adds August 2024 Marketplace apps - #10634

Merged
mjac0bs merged 8 commits into
linode:developfrom
tbaka-dev:feature/july_2024_marketplace
Jul 24, 2024
Merged

feat: [OCA-1381] - Adds August 2024 Marketplace apps#10634
mjac0bs merged 8 commits into
linode:developfrom
tbaka-dev:feature/july_2024_marketplace

Conversation

@tbaka-dev

@tbaka-dev tbaka-dev commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Description 📝

Adds new Marketplace apps for July 2024
Apache Cassandra Cluster
Apache Spark Cluster (delayed)
Openbao
Valkey
InfluxDB

Changes 🔄

List any change relevant to the reviewer.

  • updates oneClickAppsv2.ts
  • adds SVG public assets

Target release date 🗓️

July 22 2024

Important

Delayed until August 5, 2024.

@mjac0bs

mjac0bs commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

@Tbaka Is this ready to be reviewed? It's still in draft, but the target release date says July 22nd. We're cutting the release branch for 7/22 tomorrow, so this will need some eyes to make it in.

@tbaka-dev

Copy link
Copy Markdown
Contributor Author

The only thing we're missing is the svgs, they should be added today

@mjac0bs
mjac0bs marked this pull request as ready for review July 16, 2024 14:59
@mjac0bs
mjac0bs requested a review from a team as a code owner July 16, 2024 14:59
@mjac0bs
mjac0bs requested review from dwiley-akamai and jdamore-linode and removed request for a team July 16, 2024 14:59
@mjac0bs
mjac0bs self-requested a review July 16, 2024 15:00
@github-actions

github-actions Bot commented Jul 16, 2024

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 82.5%
Current Coverage: 82.5%

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a new variation to our one-click-app Launch Darkly flag for July 2024 and turned on that variation in dev. This variation will need to be served in prod after our next release in order for the July 2024 apps to display as New Apps, @carrillo-erik.

I also confirmed that the apps display and the website links and copy looks good minus one typo. I am not seeing Cassandra tagged with the cluster chip, though. Do any naming changes need to be made on the backend?

image

Comment thread packages/manager/.changeset/pr-10634-added-1721142251578.md Outdated
Comment thread packages/manager/src/features/OneClickApps/oneClickAppsv2.ts Outdated
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
@tbaka-dev

Copy link
Copy Markdown
Contributor Author

good catch @mjac0bs, the live Stackscript for Cassandra had not been added to the backend. I've taken care of that and it should display the cluster chip.

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing feedback @Tbaka - this looks good pending the remaining svgs are added, so I'm approving.

Verified cluster chip is now displaying as expected.
image

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jul 16, 2024

@dwiley-akamai dwiley-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache Cassandra Cluster, Openbao, Valkey, and InfluxDB displayed ✅
Linked website and descriptions for each look good ✅

Approved pending the addition of the remaining SVG files

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 17, 2024
@mjac0bs

mjac0bs commented Jul 17, 2024

Copy link
Copy Markdown
Contributor

We're delaying this until the August 5 release in order to have the remaining svgs ready. (cc: upcoming fire chief @jdamore-linode)

@tbaka-dev

Copy link
Copy Markdown
Contributor Author

@jdamore-linode I have added the remaining SVGs. Do you want to merge this PR, or should I resubmit it?

@mjac0bs mjac0bs changed the title feat: [OCA-1381] - adds July 2024 marketplace apps feat: [OCA-1381] - Adds August 2024 Marketplace apps Jul 24, 2024
@mjac0bs

mjac0bs commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

@Tbaka Thanks for adding. I just confirmed all the svgs are looking good and kicked off the tests. I'll merge this once they're finished and it will go out on the 08/05 release.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Marketplace

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants