Skip to content

upcoming: [M3-8320] - Add Image distributed compatibility notice to Linode Create - #10636

Merged
bnussman-akamai merged 6 commits into
linode:developfrom
bnussman-akamai:M3-8320-add-image-distributed-compatability-notice-to-linode-create
Jul 3, 2024
Merged

bnussman-akamai merged 6 commits into
linode:developfrom
bnussman-akamai:M3-8320-add-image-distributed-compatability-notice-to-linode-create

Conversation

@bnussman-akamai

@bnussman-akamai bnussman-akamai commented Jul 2, 2024

Copy link
Copy Markdown
Member

Description 📝

  • Adds a notice saying Indicates compatibility with distributed compute regions. beside the Image Select on the Linode Create flow for customers that have Images with the distributed-images capability 🌐
  • Add to both Linode Create v1 and v2 ➕
  • Added unit test for both flows 🧪

Preview 📷

Screenshot 2024-07-02 at 11 38 34 AM

How to test 🧪

Prerequisites

  • Turn on the MSW

Verification steps

Important

Please test using Linode Create v1 and v2

  • Verify you see Indicates compatibility with distributed compute regions. if the customer has >= 1 image with the distributed-images capability 🌐
  • Verify this only shows on the Images tab of the Linode Create flow 👀
  • Verify styles, alignment, and spacing look good 🎨

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai self-assigned this Jul 2, 2024
@bnussman-akamai
bnussman-akamai requested a review from a team as a code owner July 2, 2024 15:42
@bnussman-akamai
bnussman-akamai requested review from carrillo-erik and jaalah-akamai and removed request for a team July 2, 2024 15:42
@github-actions

github-actions Bot commented Jul 2, 2024

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 82.18%
Current Coverage: 82.23%

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Jul 2, 2024

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ I see the text only on the Images tab of both Create flows, it looked good at all screen sizes, and test coverage looks good.

Left a nit about the copy and a couple typos, but all non-blocking.

Comment thread packages/manager/src/components/ImageSelect/ImageSelect.test.tsx Outdated
Comment thread packages/manager/src/components/ImageSelect/ImageSelect.test.tsx Outdated
Comment thread packages/manager/src/features/Linodes/LinodeCreatev2/Tabs/Images.test.tsx Outdated
Comment thread packages/manager/src/components/ImageSelect/ImageSelect.tsx
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 3, 2024
bnussman-akamai and others added 2 commits July 3, 2024 13:36
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Image Service Gen2

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants