Skip to content

test: [M3-8155,M3-8154] - Add tests for longview client rename and deletion - #10644

Merged
AzureLatte merged 4 commits into
linode:developfrom
AzureLatte:M3-8155,M3-8154
Jul 16, 2024
Merged

AzureLatte merged 4 commits into
linode:developfrom
AzureLatte:M3-8155,M3-8154

Conversation

@AzureLatte

@AzureLatte AzureLatte commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

Description 📝

Add Cypress integration tests using mock API data to confirm the UI flow when a user renames or deletes a Longview client in Cloud Manager.

Changes 🔄

  • Add new tests in e2e longview.spec.ts
  • Add new intercepts functions in longview.ts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/longview/longview.spec.ts”

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte self-assigned this Jul 3, 2024
@AzureLatte
AzureLatte requested a review from a team as a code owner July 3, 2024 19:30
@AzureLatte
AzureLatte requested review from cliu-akamai and removed request for a team July 3, 2024 19:30
@github-actions

github-actions Bot commented Jul 3, 2024

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 82.31%
Current Coverage: 82.31%

@AzureLatte
AzureLatte requested a review from a team as a code owner July 9, 2024 15:50
@AzureLatte
AzureLatte requested review from hana-akamai and mjac0bs and removed request for a team July 9, 2024 15:50

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AzureLatte, the test cases covered the expected UI interactions and passed reliably.

I left a couple of nits about the client objects generated from factories.

Comment thread packages/manager/.changeset/pr-10644-tests-1720540166205.md Outdated
Comment thread packages/manager/cypress/e2e/core/longview/longview.spec.ts Outdated
Comment thread packages/manager/cypress/e2e/core/longview/longview.spec.ts Outdated
@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jul 9, 2024

@hana-akamai hana-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed ✅

@hana-akamai hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels Jul 11, 2024
@AzureLatte
AzureLatte merged commit 0e78061 into linode:develop Jul 16, 2024
@AzureLatte
AzureLatte deleted the M3-8155,M3-8154 branch July 16, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants