Skip to content

fix: [M3-8337] - User Preferences not being cached properly when the app loads #10663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnussman-akamai merged 3 commits into from
Jul 10, 2024
Merged

fix: [M3-8337] - User Preferences not being cached properly when the app loads #10663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b97f584
use query key factory for initial preferences fetch
bnussman Jul 10, 2024
dd51dda
Added changeset: User Preferences not properly being cached when the …
bnussman Jul 10, 2024
c335301
add back comment
bnussman Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10663-fixed-1720582006219.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

User Preferences not properly being cached when the app loads ([#10663](https://github.com/linode/manager/pull/10663))
29 changes: 7 additions & 22 deletions packages/manager/src/hooks/useInitialRequests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { getUserPreferences } from '@linode/api-v4/lib/profile';
import { useQueryClient } from '@tanstack/react-query';
import * as React from 'react';

Expand Down Expand Up @@ -47,8 +46,6 @@ export const useInitialRequests = () => {
* 1. App begins load; users see splash screen
* 2. Initial requests (in makeInitialRequests) are made (account, profile, etc.)
* 3. Initial requests complete; app is marked as done loading
* 4. As splash screen goes away, secondary requests (in makeSecondaryRequests -- Linodes, types, regions)
* are kicked off
*/
const makeInitialRequests = async () => {
// When loading Lish we avoid all this extra data loading
Expand All @@ -57,26 +54,14 @@ export const useInitialRequests = () => {
return;
}

// Initial Requests: Things we need immediately (before rendering the app)
const dataFetchingPromises: Promise<any>[] = [
// Fetch user's account information
queryClient.prefetchQuery(accountQueries.account),

// Is a user managed
queryClient.prefetchQuery(accountQueries.settings),

// Username and whether a user is restricted
queryClient.prefetchQuery(profileQueries.profile()),

// preferences
queryClient.prefetchQuery({
queryFn: getUserPreferences,
queryKey: ['preferences'],
}),
];

try {
await Promise.all(dataFetchingPromises);
// Initial Requests: Things we want immediately (before rendering the app)
await Promise.all([
queryClient.prefetchQuery(accountQueries.account),
queryClient.prefetchQuery(accountQueries.settings),
queryClient.prefetchQuery(profileQueries.profile()),
queryClient.prefetchQuery(profileQueries.preferences),
]);
} finally {
setIsLoading(false);
}
Expand Down