refactor: [M3-6901, M3-6918] - Replace react-select with Autocomplete in Domains - #10693
Merged
pmakode-akamai merged 4 commits intoJul 22, 2024
Conversation
pmakode-akamai
requested review from
carrillo-erik and
jdamore-linode
and removed request for
a team
July 18, 2024 07:21
pmakode-akamai
force-pushed
the
M3-6918-replace-select-with-autocomplete-in-domains
branch
from
July 18, 2024 07:45
3f1cb39 to
034d0f9
Compare
|
Coverage Report: ✅ |
hkhalil-akamai
approved these changes
Jul 18, 2024
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Confirmed all selects work as expected.
pmakode-akamai
added
Add'tl Approval Needed
bnussman-akamai
approved these changes
Jul 22, 2024
bnussman-akamai
added
Approved
This was referenced Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
We want to get rid of our dependency on react-select for accessibility reasons and to consolidate our usage of third-party libraries.
Changes 🔄
List any change relevant to the reviewer.
react-selectwithAutocompletecomponent within the Domains feature.Target release date 🗓️
22nd July, 2024
How to test 🧪
Verification steps
(How to verify changes)
CreateDomaincomponent continue to work as expected.DomainRecordDrawercomponent continue to work as expected.As an Author I have considered 🤔
Check all that apply