change: [M3-8376] - bump to latest design language system version - #10711
Merged
Conversation
jaalah-akamai
added
Dependencies
jaalah-akamai
marked this pull request as ready for review
July 25, 2024 15:27
jaalah-akamai
requested review from
AzureLatte and
bnussman-akamai
and removed request for
a team
July 25, 2024 15:27
jaalah-akamai
changed the title
jaalah-akamai
changed the title
Comment on lines
+2312
to
+2316
| "@tokens-studio/sd-transforms" "1.2.0" | ||
| react "^17.0.2" | ||
| react-copy-to-clipboard "^5.1.0" | ||
| react-dom "^17.0.2" | ||
| style-dictionary "4.0.0-prerelease.25" | ||
| style-dictionary "4.0.1" |
Member
There was a problem hiding this comment.
Do these dependencies need to actually be dependencies of @linode/design-language-system?
If we could make them devDependencies or peerDependencies I think it would cause Cloud Manager to not install them, making the package more "lightweight"
Contributor
Author
There was a problem hiding this comment.
Yea that's true, I'll update that with the next version 🙌
bnussman-akamai
approved these changes
Jul 25, 2024
AzureLatte
approved these changes
Jul 26, 2024
AzureLatte
left a comment
AzureLatte
left a comment
Contributor
There was a problem hiding this comment.
Changes verified. Test passed.
jaalah-akamai
added
Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
See linode/design-language-system#52 for latest changes with this version.
Changes 🔄
List any change relevant to the reviewer.
Preview 📷
Target release date 🗓️
N/A
How to test 🧪
Verification steps
(How to verify changes)