change: [M3-8382] - Update jsdom to remove WS package vulnerability - #10829
Merged
Merged
Conversation
abailly-akamai
commented
Aug 24, 2024
| whatwg-encoding "^3.1.1" | ||
| whatwg-mimetype "^4.0.0" | ||
| whatwg-url "^14.0.0" | ||
| ws "^8.18.0" |
Contributor
Author
There was a problem hiding this comment.
this is the one we need since the requirement is >= 8.17.1
abailly-akamai
marked this pull request as ready for review
August 24, 2024 01:22
abailly-akamai
requested review from
dwiley-akamai and
harsh-akamai
and removed request for
a team
August 24, 2024 01:22
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Aug 24, 2024
bnussman-akamai
left a comment
bnussman-akamai
left a comment
Member
There was a problem hiding this comment.
Nice. Thanks for getting around to these 📦
bnussman-akamai
added
the
Dependencies
harsh-akamai
approved these changes
Aug 26, 2024
This was referenced Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Small PR to mitigate a vulnerability with a sub dependency of
jsdom(ws): https://github.com/linode/manager/security/dependabot/103This is only affecting dev dependencies for our unit tests.
Changes 🔄
jsdomto24.1.1How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply