Skip to content

fix: [M3-8529] - Weblish line wrapping - #10893

Merged
abailly-akamai merged 2 commits into
linode:developfrom
abailly-akamai:M3-8529
Sep 6, 2024
Merged

abailly-akamai merged 2 commits into
linode:developfrom
abailly-akamai:M3-8529

Conversation

@abailly-akamai

@abailly-akamai abailly-akamai commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

Description 📝

When working on file edits in Weblish, current line wrapping makes it impossible to edit certain lines because of the way our columns are set up. Weblish is visually showing additional characters past 80 columns on the same line while the cursor behaves as though the line is soft wrapped.

Changes 🔄

  • Set Weblish terminal cols to 80 to match default LISH over ssh behavior

Target release date 🗓️

9/16/2024

Preview 📷

Before After
Screen.Recording.2024-09-05.at.10.50.55.mov
Screen.Recording.2024-09-05.at.10.49.52.mov

How to test 🧪

Reproduction steps

  1. Create Ubuntu 24.04 Nanode in Miami
  2. Once provisioned, click Launch LISH Console in Cloud Manager
  3. Login through Weblish as root
  4. Enter command vim /etc/ssh/sshd_config
  5. Try to edit the #Port 22 line with i to enter INSERT mode
  6. Observe you cannot use the right arrow key to move the cursor on the line

Verification steps

  • Pull code locally, and very the behavior is now fixed with the steps above

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Sep 5, 2024
@abailly-akamai abailly-akamai added the Bug Fixes for regressions or bugs label Sep 5, 2024
@abailly-akamai
abailly-akamai marked this pull request as ready for review September 5, 2024 14:53
@abailly-akamai
abailly-akamai requested a review from a team as a code owner September 5, 2024 14:53
@abailly-akamai
abailly-akamai requested review from hana-akamai and mjac0bs and removed request for a team September 5, 2024 14:53
@github-actions

github-actions Bot commented Sep 5, 2024

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 86.2%
Current Coverage: 86.2%

@bnussman-akamai bnussman-akamai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! Line wrapping and cursor position is working as expected now 🎉

Screen.Recording.2024-09-05.at.12.19.55.PM.mov

@hana-akamai hana-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@hana-akamai hana-akamai added the Approved Multiple approvals and ready to merge! label Sep 5, 2024
@abailly-akamai
abailly-akamai merged commit 1192057 into linode:develop Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants