Repository navigation
chore: Clean up unused assets & icons - #11011
Merged
bnussman-akamai merged 2 commits intoSep 27, 2024
Merged
bnussman-akamai merged 2 commits into
bnussman-akamai merged 2 commits into
Conversation
bnussman-akamai
requested review from
hana-akamai and
hkhalil-akamai
and removed request for
a team
September 26, 2024 16:49
|
Coverage Report: ✅ |
hkhalil-akamai
approved these changes
Sep 26, 2024
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
Contributor
There was a problem hiding this comment.
Everything is so satisfying about this PR, from the PR number (#11011) to the diff 😁
Changes look good, looking forward to faster git clones!
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 24m 16s |
| Commit |
|
| Committer | Banks Nussman |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
408
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
packages/manager/src/assets/icons/cloudpulse.svgwas unused. I figured I might as well do a quick clean up. We will likely be pulling all future icons from CDS 2.0 🎨How to test 🧪
Warning
There is no type-safety for assets like SVGs, but the Vite build will fail if an imported SVG does not exist
As an Author I have considered 🤔