Repository navigation
refactor: [M3-8785] - Remove feature flag, tracking events used for A/B testing in API CLI tools Modal - #11156
Merged
Merged
Conversation
This reverts commit b274baf.
cpathipa
requested review from
abailly-akamai,
cliu-akamai and
mjac0bs
and removed request for
a team
October 24, 2024 15:32
Contributor
|
@cpathipa heads up you've got a unit failing here |
mjac0bs
reviewed
Oct 28, 2024
mjac0bs
left a comment
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the clean up - this is looking good minus one unneeded prop and the unit test that still needs to be update to account for the new button copy.
|
Coverage Report: ✅ |
mjac0bs
approved these changes
Oct 29, 2024
abailly-akamai
approved these changes
Oct 29, 2024
abailly-akamai
left a comment
abailly-akamai
left a comment
Contributor
There was a problem hiding this comment.
Cleanup looks good ✅
Looking at this PR, it feels like a lot of code to cleanup for an experiment, but also it does not seem the implementation was very DRY. I think a hook would have been helpful to control the logic
mjac0bs
added
Approved
Contributor
Author
|
@abailly-akamai Good call, I will create a tech debt ticket to create a hook for firing LD tracking events to support future experiments. |
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 26m 30s |
| Commit |
|
| Committer | cpathipa |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR removes LD tracking events and feature flag used for collecting metrics for A/B testing in DX Tools Modal.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
Please specify a release date to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply